Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opentelemetry] Add DD Agent and OTel Collector ingestion tests to OTel system tests #1016

Merged
merged 16 commits into from
May 5, 2023
Merged

[opentelemetry] Add DD Agent and OTel Collector ingestion tests to OTel system tests #1016

merged 16 commits into from
May 5, 2023

Conversation

songy23
Copy link
Member

@songy23 songy23 commented Mar 28, 2023 •
edited
Loading

Description

Add DD Agent and OTel Collector ingestion tests to OTel system tests. Follow-up of #976.

The same copy of OTLP trace data will be exported via 3 ingestion paths to 3 test accounts. Runner will then get and validate traces from all accounts. To run the updated OTel E2E tests, you need 3 sets of (API key + APP key)s from 3 test accounts.

unnamed

Workflow

  1. ⚠️⚠️ Create your PR as draft (we're receiving lot of PR, it saves us lot of time) ⚠️⚠️
  2. Follows the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

NOTE: By default in PR only default scenario tests will be launched. Please refer to the documentation to run all scenarios in your PR if needed.

Once your PR is reviewed, you can merge it ! ❤️

@songy23 songy23 changed the title Add DD Agent and OTel Collector ingestion tests to OTel system tests [opentelemetry] Add DD Agent and OTel Collector ingestion tests to OTel system tests Mar 28, 2023
@songy23 songy23 force-pushed the yang.song/otlp-intake-test-2 branch 2 times, most recently from cfb85c7 to c0f8a98 Compare April 6, 2023 15:54
@songy23 songy23 force-pushed the yang.song/otlp-intake-test-2 branch from c0f8a98 to f4aee02 Compare April 21, 2023 19:17
@songy23 songy23 force-pushed the yang.song/otlp-intake-test-2 branch from f4aee02 to 765a887 Compare April 25, 2023 16:48
@songy23 songy23 requested a review from dineshg13 April 25, 2023 16:51
@songy23 songy23 marked this pull request as ready for review April 25, 2023 16:52
@songy23 songy23 requested a review from a team as a code owner April 25, 2023 16:52
@songy23 songy23 requested a review from cbeauchesne April 25, 2023 16:52
@songy23 songy23 force-pushed the yang.song/otlp-intake-test-2 branch from 65dddeb to 54b8bee Compare April 25, 2023 18:21
dineshg13
dineshg13 approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@dineshg13 dineshg13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of questions

@songy23 songy23 force-pushed the yang.song/otlp-intake-test-2 branch from be7a237 to 023e7d1 Compare May 2, 2023 12:53
@songy23
Copy link
Member Author

songy23 commented May 2, 2023

test-the-tests-open-telemetry working now! https://github.com/DataDog/system-tests/actions/runs/4861405814/jobs/8666560742?pr=1016

cbeauchesne
cbeauchesne requested changes May 2, 2023
View reviewed changes
@songy23 songy23 force-pushed the yang.song/otlp-intake-test-2 branch from 1453ed0 to 9efa949 Compare May 4, 2023 16:17
@songy23
Copy link
Member Author

songy23 commented May 5, 2023

Thanks for the review 🚀

@songy23 songy23 merged commit dcadd52 into main May 5, 2023
@songy23 songy23 deleted the yang.song/otlp-intake-test-2 branch May 5, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dineshg13 dineshg13 dineshg13 approved these changes

@cbeauchesne cbeauchesne cbeauchesne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@songy23 @dineshg13 @cbeauchesne