Skip to content

Commit

Permalink
review fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
rochdev committed Aug 1, 2024
1 parent 84cb275 commit fda1b95
Show file tree
Hide file tree
Showing 8 changed files with 16 additions and 13 deletions.
1 change: 0 additions & 1 deletion utils/build/docker/nodejs/express4-typescript/.npmrc

This file was deleted.

9 changes: 6 additions & 3 deletions utils/build/docker/nodejs/express4-typescript/app.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,16 @@ app.get('/', (req: Request, res: Response) => {
});

app.get('/healthcheck', (req: Request, res: Response) => {
const { version } = require('dd-trace/package.json')
const { wafManager } = require('dd-trace/packages/dd-trace/src/appsec/waf')

res.json({
status: 'ok',
library: {
language: 'nodejs',
version: require('dd-trace/package.json').version,
libddwaf_version: require('dd-trace/node_modules/@datadog/native-appsec/package.json').libddwaf_version,
appsec_event_rules_version: require('dd-trace/packages/dd-trace/src/appsec/waf').wafManager?.rulesVersion
version,
libddwaf_version: wafManager?.ddwafVersion,
appsec_event_rules_version: wafManager?.rulesVersion
}
});
})
Expand Down
1 change: 0 additions & 1 deletion utils/build/docker/nodejs/express4/.npmrc

This file was deleted.

9 changes: 6 additions & 3 deletions utils/build/docker/nodejs/express4/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,16 @@ app.get('/', (req, res) => {
})

app.get('/healthcheck', (req, res) => {
const { version } = require('dd-trace/package.json')
const { wafManager } = require('dd-trace/packages/dd-trace/src/appsec/waf')

res.json({
status: 'ok',
library: {
language: 'nodejs',
version: require('dd-trace/package.json').version,
libddwaf_version: require('dd-trace/node_modules/@datadog/native-appsec/package.json').libddwaf_version,
appsec_event_rules_version: require('dd-trace/packages/dd-trace/src/appsec/waf').wafManager?.rulesVersion
version,
libddwaf_version: wafManager?.ddwafVersion,
appsec_event_rules_version: wafManager?.rulesVersion
}
})
})
Expand Down
1 change: 0 additions & 1 deletion utils/build/docker/nodejs/nextjs/.npmrc

This file was deleted.

4 changes: 3 additions & 1 deletion utils/build/docker/nodejs/nextjs/next.config.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
/** @type {import('next').NextConfig} */
const nextConfig = {

// Disabled because standalone mode does not support using modules directly
// from node_modules which is necessary when using `npm link dd-trace`.
// output: 'standalone'
}

module.exports = nextConfig
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,14 @@ import { NextResponse } from 'next/server'

export async function GET (request) {
const { version } = __non_webpack_require__('dd-trace/package.json')
const pkg = __non_webpack_require__('dd-trace/node_modules/@datadog/native-appsec/package.json')
const { wafManager } = __non_webpack_require__('dd-trace/packages/dd-trace/src/appsec/waf')

return NextResponse.json({
status: 'ok',
library: {
language: 'nodejs',
version,
libddwaf_version: pkg.libddwaf_version,
libddwaf_version: wafManager?.ddwafVersion,
appsec_event_rules_version: wafManager?.rulesVersion
}
}, {
Expand Down
1 change: 0 additions & 1 deletion utils/build/docker/nodejs_otel/express4-otel/.npmrc

This file was deleted.

0 comments on commit fda1b95

Please sign in to comment.