Replace pylint by ruff for lint (#3631)

DataDog · Dec 5, 2024 · 84fc2a4 · 84fc2a4
1 parent 11f539a
commit 84fc2a4
Show file tree

Hide file tree

Showing 4 changed files with 362 additions and 38 deletions.
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -6,5 +6,7 @@
         "tests",
         "--replay"
     ],
-    "python.testing.pytestEnabled": true
+    "python.testing.pytestEnabled": true,
+    "ruff.enable": true,
+    "pylint.ignorePatterns": ["*"]
 }
diff --git a/format.sh b/format.sh
@@ -36,7 +36,7 @@ fi
 
 source venv/bin/activate
 
-echo "Checking Python files..."
+echo "Running black formatter..."
 if [ "$COMMAND" == "fix" ]; then
   black --quiet .
 else
@@ -49,9 +49,20 @@ if ! mypy --config pyproject.toml; then
   exit 1
 fi
 
-echo "Running pylint checks..."
-if ! pylint utils; then
-  echo "Pylint checks failed. Please fix the errors above. 💥 💔 💥"
+echo "Running ruff checks..."
+if ! which ruff > /dev/null; then
+  echo "ruff is not installed, installing it (ETA 5s)"
+  ./build.sh -i runner > /dev/null
+fi
+
+if [ "$COMMAND" == "fix" ]; then
+  ruff_args="--fix"
+else
+  ruff_args=""
+fi
+
+if ! ruff check $ruff_args; then
+  echo "ruff checks failed. Please fix the errors above. 💥 💔 💥"
   exit 1
 fi