Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version metadata #5448

Merged
merged 21 commits into from
Mar 17, 2020
Merged

Version metadata #5448

merged 21 commits into from
Mar 17, 2020

Conversation

hithwen
Copy link
Contributor

@hithwen hithwen commented Jan 13, 2020 •
edited
Loading

Extracts hadoop version from mapreduce integration.
Refactor response mocking
Refactor critical status raising

@stale
Copy link

stale bot commented Feb 12, 2020

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Note that this will not be automatically closed, but the notification will remind us to investigate why there's been inactivity.

@stale stale bot added the stale label Feb 12, 2020
@stale stale bot removed the stale label Feb 12, 2020
@hithwen hithwen marked this pull request as ready for review February 13, 2020 12:26
@hithwen hithwen requested a review from a team as a code owner February 13, 2020 12:26
@codecov
Copy link

codecov bot commented Feb 13, 2020 •
edited
Loading

Codecov Report

Merging #5448 into master will decrease coverage by 7.78%.
The diff coverage is 74.5%.

Impacted Files Coverage Δ
mapreduce/tests/common.py 100% <100%> (ø) ⬆️
mapreduce/tests/test_mapreduce.py 100% <100%> (ø) ⬆️
mapreduce/tests/test_mapreduce_integration_e2e.py 86.2% <100%> (ø)
mapreduce/datadog_checks/mapreduce/mapreduce.py 68.37% <45%> (-1.13%) ⬇️
mapreduce/tests/conftest.py 93.93% <89.47%> (-1.84%) ⬇️
...ts/tooling/configuration/consumers/test_example.py
...checks_dev/tests/plugin/test_environment_runner.py
oracle/tests/test_oracle.py
...r/datadog_checks/openstack_controller/__about__.py
twistlock/datadog_checks/twistlock/twistlock.py
... and 759 more

AlexandreYang
AlexandreYang requested changes Feb 17, 2020
View reviewed changes
Copy link
Member

@AlexandreYang AlexandreYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just few minor comments.

@hithwen hithwen requested a review from a team as a code owner March 3, 2020 11:07
@hithwen hithwen requested a review from a team as a code owner March 3, 2020 11:07
@hithwen hithwen requested a review from ofek March 3, 2020 11:17
sarah-witt
sarah-witt reviewed Mar 3, 2020
View reviewed changes
Copy link
Contributor

@sarah-witt sarah-witt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding enable_metadata_collection!

@hithwen @sarah-witt
Update mapreduce/setup.py
763ab95 
Co-Authored-By: Sarah Witt <[email protected]>
@hithwen hithwen requested a review from sarah-witt March 4, 2020 08:53
sarah-witt
sarah-witt previously approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@sarah-witt sarah-witt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 If tests are good!

@ChristineTChen ChristineTChen mentioned this pull request Mar 4, 2020
Merged
18 tasks
@hithwen hithwen requested a review from sarah-witt March 5, 2020 11:38
therve
therve previously approved these changes Mar 6, 2020
View reviewed changes
AlexandreYang
AlexandreYang requested changes Mar 6, 2020
View reviewed changes
Copy link
Member

@AlexandreYang AlexandreYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments.

@hithwen hithwen requested a review from AlexandreYang March 6, 2020 11:07
@hithwen hithwen merged commit 3bf7970 into master Mar 17, 2020
@hithwen hithwen deleted the julia/mapreduce-metadata branch March 17, 2020 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therve therve therve approved these changes

@AlexandreYang AlexandreYang AlexandreYang approved these changes

@ofek ofek Awaiting requested review from ofek

@sarah-witt sarah-witt Awaiting requested review from sarah-witt

Assignees
No one assigned
Labels
integration/mapreduce
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hithwen @therve @ofek @sarah-witt @AlexandreYang