Rocksdb 8 Support #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dforciea
approved these changes
Jun 22, 2023
akrylysov
reviewed
Jun 23, 2023
| @@ -6,6 +6,16 @@ import ( | |||
| "github.com/facebookgo/ensure" | |||
| ) | |||
|
|
|||
| // fatalAsError is used as a wrapper to make it possible to use ensure | |||
| // also if C calls Go otherwise it will throw a internal lockOSThread error. | |||
| type fatalAsError struct { | |||
There was a problem hiding this comment.
yes just below in this file (https://github.com/DataDog/gorocksdb/pull/28/files#diff-f22ce3b505e233e60c77c10b7ff5c1ba252b2051fa211860ace6c0ac174c05d0R28)
It was previously in filter_policy_test.go which was deleted (that functionality was deprecated/removed) so I just moved this function close to the other place it was used.
There was a problem hiding this comment.
akrylysov
approved these changes
Jun 26, 2023
|
As of March 2024 this needs an update since rocksdb_enable_file_deletions removed the "force" option |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the library to be Rocksdb 8 compatible.
The current library is not compatible with RocksDB 8+, this PR updates the bindings to be 8 compatible and adds the NewIteratorCF function to Transaction.
Key changes this PR supports:
RocksDB 8:
Remove compressed block cache
RocksDB 7:
FilterPolicy API changes for 7.0
Remove deprecated option DBOptions::max_mem_compaction_level
Remove deprecated API AdvancedColumnFamilyOptions::rate_limit_delay_max_milliseconds
Remove deprecated option DBOptions::skip_log_error_on_recovery
Remove unused option purge_redundant_kvs_while_flush