Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(otel-agent): Pin Dockerfile version in BYOC docs #27428

Merged
merged 4 commits into from
Feb 11, 2025

Conversation

krlv
Copy link
Contributor

@krlv krlv commented Feb 3, 2025

What does this PR do? What is the motivation?

  • Pin Dockerfile version to the latest stable release (7.61) instead of main
  • Bump components version to v0.114.0 in OCB manifest file
  • Switch to tagged versions of Dockerfile and OCB manifest instead of using branch (7.61.x)
  • Update docker build ... command to set build args to use agent version 7.61.0 (the default build arg agent version in the 7.61.x branch is still set to 7.57)

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

@krlv krlv requested a review from a team as a code owner February 3, 2025 20:49
@krlv krlv requested a review from brett0000FF February 3, 2025 20:49
@krlv krlv force-pushed the krlv/pin-byoc-dockerfile-verfion branch 3 times, most recently from 6866bd5 to 71310ae Compare February 11, 2025 04:13
krlv added 4 commits February 11, 2025 09:06
- Pin Dockerfile version to the latest stable release (`7.61`) instead of `main`
- Bump components version to v0.114.0 in OCB manifest file
Switch from using git branches to git tags for versioning BYOC assets
Add clarification on `main` branch being development branch (unstable) and recommendations
to use tagged version of Dockerfile and manifest file for production environment.
@krlv krlv force-pushed the krlv/pin-byoc-dockerfile-verfion branch from 71310ae to 0162607 Compare February 11, 2025 14:06
@krlv
Copy link
Contributor Author

krlv commented Feb 11, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 11, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-02-11 14:07:54 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-02-11 14:24:11 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in master is 7m.


2025-02-11 14:32:00 UTC ℹ️ MergeQueue: This merge request was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants