Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS-9915] Mobile App Performance updates for iOS and Android #27404

Merged
merged 15 commits into from
Feb 7, 2025
Merged

[DOCS-9915] Mobile App Performance updates for iOS and Android #27404

merged 15 commits into from
Feb 7, 2025

Conversation

rtrieu
Copy link
Contributor

@rtrieu rtrieu commented Jan 31, 2025 •
edited
Loading

What does this PR do? What is the motivation?

For both iOS and Android SDK:

  • Adds a new Mobile App Performance page
  • Moves relevant sections from Advanced Configuration to the new page
  • Adds new options to Advanced Configuration
  • Adds some new content to Data Collected

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

Needs a review from Eng before merging.

@rtrieu rtrieu added the WORK IN PROGRESS No review needed, it's a wip ;) label Jan 31, 2025
@rtrieu rtrieu requested a review from a team as a code owner January 31, 2025 21:48
@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Jan 31, 2025
@rtrieu rtrieu requested a review from ncreated January 31, 2025 21:48
@rtrieu rtrieu removed the WORK IN PROGRESS No review needed, it's a wip ;) label Jan 31, 2025
@github-actions GitHub Actions
Copy link
Contributor

Preview links (active after the build_preview check completes)

New or renamed files

Modified Files

@cswatt
Copy link
Contributor

cswatt commented Jan 31, 2025

created DOCS-9990 to track

@cswatt cswatt added the editorial review Waiting on a more in-depth review label Jan 31, 2025
@rtrieu @ncreated
Apply suggestions from code review
282b7a3 
Co-authored-by: Maciek Grzybowski <[email protected]>
maycmlee
maycmlee reviewed Feb 6, 2025
View reviewed changes
Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Just some small edits.

content/en/real_user_monitoring/mobile_and_tv_monitoring/android/data_collected.md Outdated Show resolved Hide resolved
content/en/real_user_monitoring/mobile_and_tv_monitoring/android/data_collected.md Outdated Show resolved Hide resolved
content/en/real_user_monitoring/mobile_and_tv_monitoring/android/monitoring_app_performance.md Outdated Show resolved Hide resolved
content/en/real_user_monitoring/mobile_and_tv_monitoring/android/monitoring_app_performance.md Outdated Show resolved Hide resolved
content/en/real_user_monitoring/mobile_and_tv_monitoring/android/monitoring_app_performance.md Outdated
All view timings are measured relative to the view's start. The exact moment a view starts depends on the type of instrumentation used for tracking views. For more details, see [Views instrumentation versus app lifecycle][2].

## Troubleshooting
When using the default TimeBasedInitialResourceIdentifier and TimeBasedInteractionIdentifier, TNS and INV timings may be missing in specific cases:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When using the default TimeBasedInitialResourceIdentifier and TimeBasedInteractionIdentifier, TNS and INV timings may be missing in specific cases:
When using the default `TimeBasedInitialResourceIdentifier` and `TimeBasedInteractionIdentifier`, TNS and INV timings may be missing in specific cases:

content/en/real_user_monitoring/mobile_and_tv_monitoring/ios/monitoring_app_performance.md Outdated Show resolved Hide resolved
content/en/real_user_monitoring/mobile_and_tv_monitoring/ios/monitoring_app_performance.md Outdated Show resolved Hide resolved
content/en/real_user_monitoring/mobile_and_tv_monitoring/ios/monitoring_app_performance.md Outdated Show resolved Hide resolved
content/en/real_user_monitoring/mobile_and_tv_monitoring/ios/data_collected.md
**SwiftUI Views**: When [tracking SwiftUI views][4] with the `.trackRUMView(name:)` view modifier, RUM starts the view at the `onAppear(perform:)` callback and stops it at `onDisappear(perform:)`.
**Manual View Tracking**: When tracking views manually using `RUMMonitor` APIs, the view starts precisely when you call the `startView(...)` method and stops when you call the `stopView()` method.

When the application leaves the foreground, RUM automatically stops the current view, leaving no active view. Since RUM's data model requires an active view to track other events, by default, all events tracked in the background are skipped due to the absence of a view. To capture these events instead, see the [Track Background Events][5].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Track Background Events" link seems to be wrong. Should it be going to: https://docs-staging.datadoghq.com/rtrieu/docs-9915-new-mobile-app-performance-page/real_user_monitoring/mobile_and_tv_monitoring/ios/advanced_configuration/?tab=swift#track-background-events

maycmlee
maycmlee approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to approve so I don't block this merge. If you need me to review anything again, just let me know!

@rtrieu rtrieu removed the editorial review Waiting on a more in-depth review label Feb 7, 2025
@rtrieu
Copy link
Contributor Author

rtrieu commented Feb 7, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 7, 2025 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2025-02-07 17:27:02 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-02-07 17:45:18 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in master is 7m.

2025-02-07 17:52:05 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 11f3b1d into master Feb 7, 2025
18 of 23 checks passed
@dd-mergequeue dd-mergequeue bot deleted the rtrieu/docs-9915-new-mobile-app-performance-page branch February 7, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncreated ncreated ncreated left review comments

@maycmlee maycmlee maycmlee approved these changes

Assignees
No one assigned
Labels
Architecture Everything related to the Doc backend mergequeue-status: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rtrieu @cswatt @ncreated @maycmlee