feat(starlette): add resource aggregation #1714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in middleware.py
…t for starlette by passing the starlette config
* added starlette to circleci config * removed starlette utils as it is not needed * checked for sleep parameter in starlette test app.py * removed starlette 12 from tox.ini
…DataDog/dd-trace-py into Isabella-Pham/starlette-auto-middleware .
* modified config variable name to integration_config in the asgi middleware
…DataDog/dd-trace-py into Isabella-Pham/starlette-auto-middleware updating branch
…DataDog/dd-trace-py into Isabella-Pham/starlette-auto-middleware Updating branch
* modified documentation in __init__.py to include "aggregate_resource" * asgi middleware checks for "aggregate_resource" in config and will aggregate resource if True * added tests to check that resources are properly aggregated upon request
…ggregate resources in the config (no need to pass anything into patch() * added more tests
…patch looking into changing the current approach from modifying the scope to modifying the span
Isabella-Pham
changed the title
majorgreys
reviewed
Oct 15, 2020
…raceMiddleware to modify the spna
…/dd-trace-py into Isabella-Pham/starlette-features updating to match master
…/dd-trace-py into Isabella-Pham/starlette-features updating code
majorgreys
previously approved these changes
Oct 16, 2020
majorgreys
dismissed stale reviews from Kyle-Verhoog and themself
via
90ecb16
majorgreys
force-pushed
the
Isabella-Pham/starlette-features
branch
from
90ecb16 to
e133491
Compare
Merged
Kyle-Verhoog
added a commit
that referenced
this pull request
Oct 19, 2020
Versions with "rc" in them seem to register as spelling mistakes. https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/3057/workflows/ab9bf51f-d338-4bff-8549-08e02d4cbcf1/jobs/358186 @majorgreys introduced this fix to solve the issue in #1714. Co-authored-by: Tahir H. Butt <[email protected]>
Kyle-Verhoog
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current Starlette integration uses ASGI middleware and does not have Starlette specific features. This change adds Starlette specific features to the Starlette integration.
Checklist