Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pyramid): fix flaky test for pyramid as of Feb 2025 #12486

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

wantsui
Copy link
Collaborator

@wantsui wantsui commented Feb 21, 2025

We can remove the flaky decorator on test_simple_pyramid_app_endpoint unless it isn't spinning up in CI. I was able to make this test pass locally after removing the flaky decorator.

If the CI is throwing 404 errors over the snapshot, then it likely doesn't have access to the test agent (which is what happened to me when I ran it locally).

Note: Sample command to test this

scripts/ddtest
DD_TRACE_AGENT_PORT=9126 riot -v run --pass-env -s <some hash> -k test_simple_pyramid_app_endpoint

Additionally, the service name changed and I had to make an adjustment for that.

Update Turns out this is actually failing in CI despite passing locally.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

… was the snapshot that seemed to be missing but the test itself is fine and doesn't test for spans.
…this to return something, and also the snapshot had the wrong service name.
@wantsui wantsui requested a review from quinna-h February 21, 2025 23:43
Copy link
Contributor

CODEOWNERS have been resolved as:

tests/contrib/pyramid/test_pyramid.py                                   @DataDog/apm-core-python @DataDog/apm-idm-python
tests/snapshots/tests.contrib.pyramid.test_pyramid.test_simple_pyramid_app_endpoint[ddtrace-run_pserve_tests_contrib_pyramid_pserve_app_development.ini].json  @DataDog/apm-python

@wantsui wantsui added the changelog/no-changelog A changelog entry is not required for this PR. label Feb 21, 2025
@wantsui wantsui changed the title chore: fix flaky test for pyramid as of Feb 2025 chore(pyramid): fix flaky test for pyramid as of Feb 2025 Feb 21, 2025
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: wantsui/fix-pyramid-flaky
Commit report: 8437e71
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1125 Skipped, 1m 46.26s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Feb 22, 2025

Benchmarks

Benchmark execution time: 2025-02-22 01:26:59

Comparing candidate commit 162eb44 in PR branch wantsui/fix-pyramid-flaky with baseline commit fc6973d in branch main.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 416 metrics, 2 unstable metrics.

scenario:iast_aspects-ospathbasename_aspect

  • 🟥 execution_time [+348.654ns; +407.844ns] or [+10.762%; +12.589%]

scenario:iast_aspects-ospathdirname_aspect

  • 🟥 execution_time [+360.176ns; +425.832ns] or [+9.812%; +11.601%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant