ci: requires virtualenv < 20 #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettlangdon
previously approved these changes
Feb 26, 2020
.circleci/config.yml
Outdated
| @@ -701,7 +701,7 @@ jobs: | |||
| # debug: shows how many time each test was executed | |||
| - run: jq -s ".[]|.testenvs|keys|.[]" /tmp/workspace/* | grep -v GLOB | sed 's/"//g' | sort | uniq -c | sort -rn | |||
| # list all executed test | |||
| - run: jq -s ".[]|.testenvs|keys|.[]" /tmp/workspace/* | grep -v GLOB | sed 's/"//g' | sort | uniq | tee all_executed_tests | |||
| - run: jq -s ".[]|.testenvs|keys|.[]" /tmp/workspace/* | grep -v GLOB | sed 's/"//g' | sort | uniq | grep -v '^\.' | tee all_executed_tests | |||
There was a problem hiding this comment.
why is this changing?
did we change it before because of an update in virtualenv and now rolling it back?
There was a problem hiding this comment.
This is because the requires parameter creates a new "hidden" pre-step that is listed here.
This is a special one and it starts with a . so it's an easy way to identify.
The same happens when you use isolated_build (see #1203)
jd
force-pushed
the
fix-celery
branch
2 times, most recently
from
5c5a7eb to
6811282
Compare
brettlangdon
previously approved these changes
Feb 26, 2020
There's a regression in virtualenv >= 20 that makes one of the ddtrace-run + Celery test to fails. virtualenv now adds a site.py which modifies sys.path and breaks the PYTHONPATH that is set by ddtrace-run.
|
Bug opened on virtualenv: pypa/virtualenv#1670 |
majorgreys
approved these changes
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a regression in virtualenv >= 20 that makes one of the ddtrace-run +
Celery test to fails.
virtualenv now adds a site.py which modifies sys.path and breaks the PYTHONPATH
that is set by ddtrace-run.