chore(tests): fix tz warning #11497
Merged
chore(tests): fix tz warning #11497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kyle-Verhoog
added
the
changelog/no-changelog
|
|
Running the tests locally, I get: ``` DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC ``` The recommended upgrade is to use `datetime.now(timezone.utc)` which is what is done here.
Kyle-Verhoog
force-pushed
the
kylev/fix-tz-warning
branch
from
50ee5fc to
317a83b
Compare
Datadog ReportBranch report: ✅ 0 Failed, 918 Passed, 550 Skipped, 14m 3.94s Total duration (22m 0.6s time saved) |
emmettbutler
approved these changes
Nov 22, 2024
2 tasks
wantsui
added a commit
that referenced
this pull request
Jan 9, 2025
…1850) See #11608 and #11497. Starting with [Python 3.12](https://docs.python.org/3/whatsnew/3.12.html), there were changes to datetime: > [datetime](https://docs.python.org/3/library/datetime.html#module-datetime): [datetime.datetime](https://docs.python.org/3/library/datetime.html#datetime.datetime)’s [utcnow()](https://docs.python.org/3/library/datetime.html#datetime.datetime.utcnow) and [utcfromtimestamp()](https://docs.python.org/3/library/datetime.html#datetime.datetime.utcfromtimestamp) are deprecated and will be removed in a future version. Instead, use timezone-aware objects to represent datetimes in UTC: respectively, call [now()](https://docs.python.org/3/library/datetime.html#datetime.datetime.now) and [fromtimestamp()](https://docs.python.org/3/library/datetime.html#datetime.datetime.fromtimestamp) with the tz parameter set to [datetime.UTC](https://docs.python.org/3/library/datetime.html#datetime.UTC). (Contributed by Paul Ganssle in [gh-103857](python/cpython#103857).) The result is that the usage of **utcnow** and **utcfromtimestamp** now throw deprecation warnings when used, ie: > DeprecationWarning: datetime.datetime.utcfromtimestamp() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.fromtimestamp(timestamp, datetime.UTC). There's a difference of `+00:00` between the old version and the new format. **For utcnow -> now** - `datetime.datetime.utcnow().isoformat()` | `'2025-01-02T19:51:32.579733'` - `datetime.datetime.now(datetime.timezone.utc).isoformat()` | `'2025-01-02T19:51:02.275232+00:00'` **For utcfromtimestamp -> fromtimestamp** Assume that `end_time_ns=1735848645000000000`: - `(datetime.datetime.fromtimestamp(end_time_ns / 1e9, tz=datetime.timezone.utc).replace(microsecond=0).isoformat() + "Z")` - returns `'2025-01-02T20:10:45+00:00Z'` - `(datetime.datetime.utcfromtimestamp(end_time_ns / 1e9).replace(microsecond=0).isoformat() + "Z")` - returns `'2025-01-02T20:10:45Z'` As a result, I attempted remove the trailing ones to be consistent with the old format, but can bring it back. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the tests locally, I get:
The recommended upgrade is to use
datetime.now(timezone.utc)which is what is done here.Checklist
Reviewer Checklist