Skip to content

Commit

Permalink
add base_url to llmobs spans in open ai integration
Browse files Browse the repository at this point in the history
  • Loading branch information
ncybul committed Feb 20, 2025
1 parent 7011d3c commit e00fab1
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 1 deletion.
1 change: 1 addition & 0 deletions ddtrace/llmobs/_constants.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
SPAN_KIND = "_ml_obs.meta.span.kind"
SESSION_ID = "_ml_obs.session_id"
METADATA = "_ml_obs.meta.metadata"
BASE_URL = "_ml_obs.base_url"
METRICS = "_ml_obs.metrics"
ML_APP = "_ml_obs.meta.ml_app"
PROPAGATED_PARENT_ID_KEY = "_dd.p.llmobs_parent_id"
Expand Down
4 changes: 3 additions & 1 deletion ddtrace/llmobs/_integrations/openai.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

from ddtrace.internal.constants import COMPONENT
from ddtrace.internal.utils.version import parse_version
from ddtrace.llmobs._constants import BASE_URL
from ddtrace.llmobs._constants import INPUT_DOCUMENTS
from ddtrace.llmobs._constants import INPUT_MESSAGES
from ddtrace.llmobs._constants import INPUT_TOKENS_METRIC_KEY
Expand Down Expand Up @@ -113,6 +114,7 @@ def _llmobs_set_tags(
"""Sets meta tags and metrics for span events to be sent to LLMObs."""
span_kind = "embedding" if operation == "embedding" else "llm"
model_name = span.get_tag("openai.response.model") or span.get_tag("openai.request.model")
base_url = span.get_tag("openai.base_url")

model_provider = "openai"
if self._is_provider(span, "azure"):
Expand All @@ -128,7 +130,7 @@ def _llmobs_set_tags(
self._llmobs_set_meta_tags_from_embedding(span, kwargs, response)
metrics = self._extract_llmobs_metrics_tags(span, response)
span._set_ctx_items(
{SPAN_KIND: span_kind, MODEL_NAME: model_name or "", MODEL_PROVIDER: model_provider, METRICS: metrics}
{SPAN_KIND: span_kind, MODEL_NAME: model_name or "", MODEL_PROVIDER: model_provider, METRICS: metrics, BASE_URL: base_url}
)

@staticmethod
Expand Down
2 changes: 2 additions & 0 deletions ddtrace/llmobs/_llmobs.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
from ddtrace.llmobs import _constants as constants
from ddtrace.llmobs._constants import AGENTLESS_BASE_URL
from ddtrace.llmobs._constants import ANNOTATIONS_CONTEXT_ID
from ddtrace.llmobs._constants import BASE_URL
from ddtrace.llmobs._constants import INPUT_DOCUMENTS
from ddtrace.llmobs._constants import INPUT_MESSAGES
from ddtrace.llmobs._constants import INPUT_PROMPT
Expand Down Expand Up @@ -227,6 +228,7 @@ def _llmobs_tags(span: Span, ml_app: str, session_id: Optional[str] = None) -> L
"ddtrace.version": ddtrace.__version__,
"language": "python",
"error": span.error,
"base_url": span._get_ctx_item(BASE_URL),
}
err_type = span.get_tag(ERROR_TYPE)
if err_type:
Expand Down

0 comments on commit e00fab1

Please sign in to comment.