[test optimization] Add support for Drone CI #5304

Mariovido · 2025-02-20T14:54:41Z

What does this PR do?

This PR is intended to add support for Drone CI.

Motivation

We want to increase our support in the main stream CI providers.

Plugin Checklist

Additional Notes

github-actions · 2025-02-20T14:55:38Z

Overall package size

Self size: 8.77 MB
Deduped: 94.97 MB
No deduping: 95.48 MB

Dependency sizes

| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

_{🤖 This report was automatically generated by heaviest-objects-in-the-universe}

codecov · 2025-02-20T14:56:11Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.94%. Comparing base (96bb84a) to head (b62853c).
Report is 2 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5304   +/-   ##
=======================================
  Coverage   80.94%   80.94%           
=======================================
  Files         488      488           
  Lines       21844    21847    +3     
=======================================
+ Hits        17681    17684    +3     
  Misses       4163     4163

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

datadog-datadog-prod-us1 · 2025-02-20T15:01:09Z

Datadog Report

Branch report: mario.vidal/add_support_drone_ci
Commit report: 946f184
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 663 Passed, 0 Skipped, 10m 38.62s Total Time

pr-commenter · 2025-02-20T16:27:39Z

Benchmarks

Benchmark execution time: 2025-02-24 11:54:12

Comparing candidate commit b62853c in PR branch mario.vidal/add_support_drone_ci with baseline commit 96bb84a in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 916 metrics, 17 unstable metrics.

juan-fernandez · 2025-02-21T10:03:24Z

packages/dd-trace/src/plugins/util/ci.js

+        [CI_JOB_NAME]: DRONE_STEP_NAME,
+        [CI_STAGE_NAME]: DRONE_STAGE_NAME,
+        [CI_WORKSPACE_PATH]: DRONE_WORKSPACE,
+        [CI_ENV_VARS]: JSON.stringify({ }), // MISSING


I don't think we need to add this if we have nothing

juan-fernandez · 2025-02-21T10:03:43Z

packages/dd-trace/src/plugins/util/ci.js

+        [CI_PIPELINE_NAME]: DRONE_REPO_NAME,
+        [CI_PIPELINE_NUMBER]: DRONE_BUILD_NUMBER,
+        [CI_PIPELINE_URL]: DRONE_BUILD_LINK,
+        [CI_JOB_URL]: 'XXX', // MISSING


it's a pity we don't have this, but it's OK, we can leave it empty

juan-fernandez · 2025-02-21T10:04:11Z

packages/dd-trace/src/plugins/util/ci.js

+        [GIT_COMMIT_AUTHOR_DATE]: 'XXX', // MISSING
+        [GIT_COMMIT_COMMITTER_NAME]: 'XXX', // MISSING
+        [GIT_COMMIT_COMMITTER_EMAIL]: 'XXX', // MISSING


we can leave this empty too. These tags specifically will be filled by our git commands

juan-fernandez · 2025-02-21T11:19:49Z

packages/dd-trace/src/plugins/util/ci.js

+      tags = {
+        [CI_PROVIDER_NAME]: 'drone',
+        [CI_PIPELINE_ID]: DRONE_BUILD_NUMBER,
+        [CI_PIPELINE_NAME]: DRONE_REPO_NAME,


we can remove this too

I removed the pipeline_id and pipeline_name

juan-fernandez

LGTM! Only a minor comment

juan-fernandez · 2025-02-24T11:35:26Z

packages/dd-trace/test/plugins/util/ci-env/droneci.json

@@ -0,0 +1,35 @@
+[


nitpick: let's name this file the same as the ci.provider.name tag. In this case it'd be drone.json

juan-fernandez

🎉

First iteration of correlation of env variables

388cae6

Mariovido added ci-app semver-patch labels Feb 20, 2025

Add tests

8bc852e

Merge branch 'master' into mario.vidal/add_support_drone_ci

fdf9032

juan-fernandez reviewed Feb 21, 2025

View reviewed changes

Mariovido added 2 commits February 21, 2025 14:19

Update json files

d01b36d

Add drone.ci

ed95ab0

Mariovido marked this pull request as ready for review February 21, 2025 14:03

Mariovido requested review from a team as code owners February 21, 2025 14:03

Mariovido requested a review from juan-fernandez February 21, 2025 14:03

juan-fernandez reviewed Feb 24, 2025

View reviewed changes

Mariovido added 2 commits February 24, 2025 12:40

Change step name value

852903c

Renamed value

b62853c

juan-fernandez approved these changes Feb 24, 2025

View reviewed changes

Mariovido merged commit 213cbe1 into master Feb 24, 2025
395 checks passed

Mariovido deleted the mario.vidal/add_support_drone_ci branch February 24, 2025 16:17

sabrenner pushed a commit that referenced this pull request Feb 24, 2025

[test optimization] Add support for Drone CI (#5304)

969b28a

sabrenner mentioned this pull request Feb 24, 2025

v5.38.0 proposal #5312

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[test optimization] Add support for Drone CI #5304

[test optimization] Add support for Drone CI #5304

Mariovido commented Feb 20, 2025

github-actions bot commented Feb 20, 2025 •

edited

Loading

codecov bot commented Feb 20, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot commented Feb 20, 2025 •

edited

Loading

pr-commenter bot commented Feb 20, 2025 •

edited

Loading

juan-fernandez Feb 21, 2025

Mariovido Feb 21, 2025

juan-fernandez Feb 21, 2025

Mariovido Feb 21, 2025

juan-fernandez Feb 21, 2025

Mariovido Feb 21, 2025

juan-fernandez Feb 21, 2025

Mariovido Feb 21, 2025

juan-fernandez left a comment

juan-fernandez Feb 24, 2025

Mariovido Feb 24, 2025

juan-fernandez left a comment

[test optimization] Add support for Drone CI #5304

[test optimization] Add support for Drone CI #5304

Conversation

Mariovido commented Feb 20, 2025

What does this PR do?

Motivation

Plugin Checklist

Additional Notes

github-actions bot commented Feb 20, 2025 • edited Loading

Overall package size

codecov bot commented Feb 20, 2025 • edited Loading

Codecov Report

datadog-datadog-prod-us1 bot commented Feb 20, 2025 • edited Loading

Datadog Report

pr-commenter bot commented Feb 20, 2025 • edited Loading

Benchmarks

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

juan-fernandez left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

juan-fernandez left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 20, 2025 •

edited

Loading

codecov bot commented Feb 20, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot commented Feb 20, 2025 •

edited

Loading

pr-commenter bot commented Feb 20, 2025 •

edited

Loading