Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TraceProvider Constructors Typings #4596

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

khanayan123
Copy link
Collaborator

What does this PR do?

update index.d.ts to include config object for TraceProvider constructor

Motivation

typescript error when trying to pass in a config object during TraceProvider instance construction

@khanayan123 khanayan123 requested a review from a team as a code owner August 12, 2024 04:18
Copy link

github-actions bot commented Aug 12, 2024

Overall package size

Self size: 6.95 MB
Deduped: 58.17 MB
No deduping: 58.45 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.0.1 | 15.59 MB | 15.6 MB | | @datadog/native-iast-taint-tracking | 3.1.0 | 12.27 MB | 12.28 MB | | @datadog/pprof | 5.3.0 | 9.85 MB | 10.22 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.4.1 | 2.14 MB | 2.23 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.8.1 | 71.67 kB | 785.15 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | lru-cache | 7.14.0 | 74.95 kB | 74.95 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.7 | 6.78 kB | 6.78 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@khanayan123 khanayan123 force-pushed the khanayan123/add-constructor-type-for-trace-provider branch from 2c18aad to d50450b Compare August 12, 2024 04:19
@pr-commenter
Copy link

pr-commenter bot commented Aug 12, 2024

Benchmarks

Benchmark execution time: 2024-08-12 04:28:57

Comparing candidate commit d50450b in PR branch khanayan123/add-constructor-type-for-trace-provider with baseline commit 77c1d07 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 260 metrics, 6 unstable metrics.

@bengl bengl merged commit 15bc4a5 into master Aug 12, 2024
175 checks passed
@bengl bengl deleted the khanayan123/add-constructor-type-for-trace-provider branch August 12, 2024 19:26
@uurien uurien mentioned this pull request Aug 13, 2024
uurien pushed a commit that referenced this pull request Aug 13, 2024
* update index.d.ts to include config object for TraceProvider constructor

* update typing
@uurien uurien mentioned this pull request Aug 13, 2024
uurien pushed a commit that referenced this pull request Aug 13, 2024
* update index.d.ts to include config object for TraceProvider constructor

* update typing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants