Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send original config value to telemetry #4378

Merged
merged 6 commits into from
Jun 7, 2024
Merged

Conversation

ida613
Copy link
Collaborator

@ida613 ida613 commented Jun 5, 2024

What does this PR do?

Send the original user input (whether through env var, parameter passed into Config, or remote config) to telemetry

Motivation

Telemetry is supposed to report the original user input value, not the config values end up being set after validation. This is so the user can know when they put in an invalid value, and what exactly that is.
This change is a bandage solution, in the future we would want to change the architecture to make it more intuitive.

Plugin Checklist

Additional Notes

Copy link

github-actions bot commented Jun 5, 2024

Overall package size

Self size: 6.62 MB
Deduped: 61.88 MB
No deduping: 62.16 MB

Dependency sizes

name version self size total size
@datadog/native-appsec 8.0.1 15.59 MB 15.6 MB
@datadog/native-iast-taint-tracking 2.1.0 14.91 MB 14.92 MB
@datadog/pprof 5.3.0 9.85 MB 10.22 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.3.1 2.15 MB 2.24 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.8.0 1.21 MB 1.21 MB
import-in-the-middle 1.7.4 70.19 kB 739.86 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
pprof-format 2.1.0 111.69 kB 111.69 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Jun 5, 2024

Benchmarks

Benchmark execution time: 2024-06-07 14:23:09

Comparing candidate commit ccf3cbe in PR branch ida613/update-telemetry with baseline commit 6c43686 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 3 unstable metrics.

@ida613 ida613 marked this pull request as ready for review June 5, 2024 14:03
@ida613 ida613 requested a review from a team as a code owner June 5, 2024 14:03
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.19%. Comparing base (02dc5ce) to head (ccf3cbe).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4378   +/-   ##
=======================================
  Coverage   69.19%   69.19%           
=======================================
  Files           1        1           
  Lines         198      198           
  Branches       33       33           
=======================================
  Hits          137      137           
  Misses         61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ida613 ida613 merged commit 743676c into master Jun 7, 2024
133 checks passed
@ida613 ida613 deleted the ida613/update-telemetry branch June 7, 2024 16:59
ida613 added a commit that referenced this pull request Jun 7, 2024
* send original config values to telemetry

---------

Co-authored-by: Thomas Hunter II <[email protected]>
ida613 added a commit that referenced this pull request Jun 7, 2024
* send original config values to telemetry

---------

Co-authored-by: Thomas Hunter II <[email protected]>
ida613 added a commit that referenced this pull request Jun 7, 2024
* send original config values to telemetry

---------

Co-authored-by: Thomas Hunter II <[email protected]>
@ida613 ida613 mentioned this pull request Jun 7, 2024
ida613 added a commit that referenced this pull request Jun 7, 2024
* send original config values to telemetry

---------

Co-authored-by: Thomas Hunter II <[email protected]>
@ida613 ida613 mentioned this pull request Jun 7, 2024
ida613 added a commit that referenced this pull request Jun 10, 2024
* send original config values to telemetry

---------

Co-authored-by: Thomas Hunter II <[email protected]>
ida613 added a commit that referenced this pull request Jun 10, 2024
ida613 added a commit that referenced this pull request Jun 10, 2024
* send original config values to telemetry

---------

Co-authored-by: Thomas Hunter II <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants