-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send original config value to telemetry #4378
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overall package sizeSelf size: 6.62 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
…-js into ida613/update-telemetry
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4378 +/- ##
=======================================
Coverage 69.19% 69.19%
=======================================
Files 1 1
Lines 198 198
Branches 33 33
=======================================
Hits 137 137
Misses 61 61 ☔ View full report in Codecov by Sentry. |
bengl
approved these changes
Jun 7, 2024
bengl
approved these changes
Jun 7, 2024
ida613
added a commit
that referenced
this pull request
Jun 7, 2024
* send original config values to telemetry --------- Co-authored-by: Thomas Hunter II <[email protected]>
ida613
added a commit
that referenced
this pull request
Jun 7, 2024
* send original config values to telemetry --------- Co-authored-by: Thomas Hunter II <[email protected]>
ida613
added a commit
that referenced
this pull request
Jun 7, 2024
* send original config values to telemetry --------- Co-authored-by: Thomas Hunter II <[email protected]>
Merged
ida613
added a commit
that referenced
this pull request
Jun 7, 2024
* send original config values to telemetry --------- Co-authored-by: Thomas Hunter II <[email protected]>
Merged
ida613
added a commit
that referenced
this pull request
Jun 10, 2024
* send original config values to telemetry --------- Co-authored-by: Thomas Hunter II <[email protected]>
ida613
added a commit
that referenced
this pull request
Jun 10, 2024
* send original config values to telemetry --------- Co-authored-by: Thomas Hunter II <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Send the original user input (whether through env var, parameter passed into Config, or remote config) to telemetry
Motivation
Telemetry is supposed to report the original user input value, not the config values end up being set after validation. This is so the user can know when they put in an invalid value, and what exactly that is.
This change is a bandage solution, in the future we would want to change the architecture to make it more intuitive.
Plugin Checklist
Additional Notes