Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exploit prevention monitoring ssrf #4361

Merged
merged 15 commits into from
Jun 4, 2024
Merged

Conversation

uurien
Copy link
Collaborator

@uurien uurien commented May 30, 2024

What does this PR do?

First step of exploit prevention feature. Call to the waf to detect threats in ssrf sink point.

Motivation

Start rasp implementation with small and reviewable Pull requests

Plugin Checklist

  • Unit tests.

Additional Notes

APPSEC-47583

Copy link

github-actions bot commented May 30, 2024

Overall package size

Self size: 6.6 MB
Deduped: 61.85 MB
No deduping: 62.13 MB

Dependency sizes

name version self size total size
@datadog/native-appsec 8.0.1 15.59 MB 15.6 MB
@datadog/native-iast-taint-tracking 2.1.0 14.91 MB 14.92 MB
@datadog/pprof 5.3.0 9.85 MB 10.22 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.3.1 2.15 MB 2.24 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.8.0 1.21 MB 1.21 MB
import-in-the-middle 1.7.4 70.19 kB 739.86 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
pprof-format 2.1.0 111.69 kB 111.69 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@uurien uurien changed the title Ugaitz/rasp ssrf monitoring rasp ssrf monitoring May 30, 2024
@uurien uurien changed the title rasp ssrf monitoring Exploit prevention monitoring ssrf May 30, 2024
@pr-commenter
Copy link

pr-commenter bot commented May 30, 2024

Benchmarks

Benchmark execution time: 2024-06-04 06:35:43

Comparing candidate commit b7f9bfe in PR branch ugaitz/rasp-ssrf-monitoring with baseline commit 2d8b5af in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 259 metrics, 6 unstable metrics.

scenario:plugin-graphql-with-depth-and-collapse-on-18

  • 🟩 max_rss_usage [-136.602MB; -129.758MB] or [-14.076%; -13.371%]

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.19%. Comparing base (557814a) to head (b7f9bfe).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4361      +/-   ##
==========================================
+ Coverage   63.77%   69.19%   +5.41%     
==========================================
  Files         246        1     -245     
  Lines       10546      198   -10348     
  Branches       33       33              
==========================================
- Hits         6726      137    -6589     
+ Misses       3820       61    -3759     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uurien uurien marked this pull request as ready for review May 30, 2024 13:09
@uurien uurien requested review from a team as code owners May 30, 2024 13:09
index.d.ts Show resolved Hide resolved
Copy link
Member

@simon-id simon-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, couple of questions, but otherwise LGTM, i'll approve once we resolve the threads. Also love the assert uses instead of expect <3

@uurien uurien merged commit 9b410b7 into master Jun 4, 2024
133 checks passed
@uurien uurien deleted the ugaitz/rasp-ssrf-monitoring branch June 4, 2024 08:19
juan-fernandez pushed a commit that referenced this pull request Jun 4, 2024
---------

Co-authored-by: Carles Capell <[email protected]>
juan-fernandez pushed a commit that referenced this pull request Jun 4, 2024
---------

Co-authored-by: Carles Capell <[email protected]>
juan-fernandez pushed a commit that referenced this pull request Jun 5, 2024
---------

Co-authored-by: Carles Capell <[email protected]>
juan-fernandez pushed a commit that referenced this pull request Jun 5, 2024
---------

Co-authored-by: Carles Capell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants