Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Serverless Mini Agent for Azure Functions on All Plans #4304

Merged
merged 4 commits into from
May 16, 2024

Conversation

duncanpharvey
Copy link
Contributor

@duncanpharvey duncanpharvey commented May 14, 2024

What does this PR do?

Run Serverless Mini Agent for Azure Functions on all plans (not just consumption).

Motivation

https://datadoghq.atlassian.net/browse/SVLS-4805

Plugin Checklist

Additional Notes

Copy link

github-actions bot commented May 14, 2024

Overall package size

Self size: 6.47 MB
Deduped: 59.18 MB
No deduping: 59.46 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 2.1.0 14.91 MB 14.92 MB
@datadog/native-appsec 7.1.1 14.39 MB 14.4 MB
@datadog/pprof 5.2.0 8.84 MB 9.21 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.3.1 2.15 MB 2.24 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.7.4 70.19 kB 739.86 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
pprof-format 2.1.0 111.69 kB 111.69 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.19%. Comparing base (7000ae5) to head (3a6f8f0).
Report is 10 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4304   +/-   ##
=======================================
  Coverage   69.19%   69.19%           
=======================================
  Files           1        1           
  Lines         198      198           
  Branches       33       33           
=======================================
  Hits          137      137           
  Misses         61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented May 14, 2024

Benchmarks

Benchmark execution time: 2024-05-16 03:31:56

Comparing candidate commit 3a6f8f0 in PR branch duncan-harvey/serverless-mini-agent-azure-functions with baseline commit 79f0d64 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 259 metrics, 6 unstable metrics.

scenario:plugin-graphql-with-depth-on-max-18

  • 🟩 max_rss_usage [-120.804MB; -98.148MB] or [-12.790%; -10.391%]

@duncanpharvey duncanpharvey changed the title enable serverless mini agent for azure functions on all plans Enable Serverless Mini Agent for Azure Functions on All Plans May 14, 2024
@duncanpharvey duncanpharvey marked this pull request as ready for review May 16, 2024 12:40
@duncanpharvey duncanpharvey requested a review from a team as a code owner May 16, 2024 12:40
@duncanpharvey duncanpharvey requested a review from a team May 16, 2024 12:42
Copy link

@jcstorms1 jcstorms1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@duncanpharvey
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 16, 2024

🚂 MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@tlhunter tlhunter merged commit 12d02ee into master May 16, 2024
112 of 114 checks passed
@tlhunter tlhunter deleted the duncan-harvey/serverless-mini-agent-azure-functions branch May 16, 2024 17:22
@dd-devflow
Copy link

dd-devflow bot commented May 16, 2024

🚂 MergeQueue

This pull request was merged directly.

khanayan123 pushed a commit that referenced this pull request May 16, 2024
khanayan123 pushed a commit that referenced this pull request May 16, 2024
This was referenced May 16, 2024
khanayan123 pushed a commit that referenced this pull request May 17, 2024
khanayan123 pushed a commit that referenced this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants