Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci-visibility] Fix test source file to be relative to the repository root #4030

Merged
merged 11 commits into from
Feb 12, 2024

Conversation

juan-fernandez
Copy link
Collaborator

@juan-fernandez juan-fernandez commented Feb 5, 2024

What does this PR do?

Change the root file we use for calculating the relative path of source files: instead of using process.cwd we attempt to use the repository root. If we can't find it, we'll still fall back to process.cwd.

Motivation

test.source.file should always be relative to the repository root. Otherwise our UI will not be able to show source code.

Plugin Checklist

  • Unit tests.

Security

Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

Copy link

github-actions bot commented Feb 5, 2024

Overall package size

Self size: 6.02 MB
Deduped: 61.62 MB
No deduping: 62.38 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.6.4 16.43 MB 16.44 MB
@datadog/native-appsec 7.0.0 14.51 MB 14.52 MB
@datadog/pprof 5.0.0 9.59 MB 10.44 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.2.3 2.19 MB 2.28 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.7.3 67.62 kB 731.01 kB
pprof-format 2.0.7 588.12 kB 588.12 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (a425f89) 85.32% compared to head (561607c) 85.43%.

Files Patch % Lines
packages/datadog-plugin-mocha/src/index.js 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4030      +/-   ##
==========================================
+ Coverage   85.32%   85.43%   +0.10%     
==========================================
  Files         243      243              
  Lines       10554    10558       +4     
  Branches       33       33              
==========================================
+ Hits         9005     9020      +15     
+ Misses       1549     1538      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Feb 5, 2024

Benchmarks

Benchmark execution time: 2024-02-09 15:49:05

Comparing candidate commit 561607c in PR branch juan-fernandez/fix-test-source-file with baseline commit a425f89 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 260 metrics, 5 unstable metrics.

scenario:plugin-graphql-with-depth-off-18

  • 🟩 max_rss_usage [-143.052MB; -84.136MB] or [-15.043%; -8.848%]

@juan-fernandez juan-fernandez changed the title [ci-visibility] Change test source file [ci-visibility] Fix test source file to be relative to the repository root Feb 5, 2024
@juan-fernandez juan-fernandez force-pushed the juan-fernandez/fix-test-source-file branch from 83850bc to ec79359 Compare February 7, 2024 16:36
@juan-fernandez juan-fernandez force-pushed the juan-fernandez/fix-test-source-file branch from e670b54 to c73cdef Compare February 9, 2024 09:57
@juan-fernandez juan-fernandez marked this pull request as ready for review February 9, 2024 10:56
@juan-fernandez juan-fernandez requested review from a team as code owners February 9, 2024 10:56
Copy link
Contributor

@romainkomorn-exdatadog romainkomorn-exdatadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm tempted to say you should just make getTestSuitePath find the repository root on its own so that you don't repeat the same if/else statement each time, but maybe that's not practical so I'll still approve.

@juan-fernandez
Copy link
Collaborator Author

I'm tempted to say you should just make getTestSuitePath find the repository root on its own so that you don't repeat the same if/else statement each time, but maybe that's not practical so I'll still approve.

that might be hard, given that the repository root has two possible origins:

  • CI tags
  • git command

while I could make the function "git aware", making it CI tags aware would be awkward. I need to find a better solution for tags calculation, as it's increasing in complexity non stop 😅

@juan-fernandez juan-fernandez merged commit 7561fb5 into master Feb 12, 2024
110 of 111 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants