[ci-visibility] Fix appClosing telemetry event

[juan-fernandez]

What does this PR do?

appClosing is called in cypress and playwright but it could be done when telemetry is disabled. By checking it first we make sure we don't attempt to create telemetry events when we shouldn't.

Unrelated change: after #4021 the code owners logic change so now the plugin tests are getting the root CODEOWNERS. I've updated the plugin tests to reflect this.

Motivation

Fix cypress plugin errors.

Security

Datadog employees:

• If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
• This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

[github-actions]

Overall package size

Self size: 5.97 MB
Deduped: 61.57 MB
No deduping: 62.32 MB

Dependency sizes

name	version	self size	total size
@datadog/native-iast-taint-tracking	1.6.4	16.43 MB	16.44 MB
@datadog/native-appsec	7.0.0	14.51 MB	14.52 MB
@datadog/pprof	5.0.0	9.59 MB	10.44 MB
protobufjs	7.2.5	2.77 MB	6.56 MB
@datadog/native-iast-rewriter	2.2.3	2.19 MB	2.28 MB
@opentelemetry/core	1.14.0	872.87 kB	1.47 MB
@datadog/native-metrics	2.0.0	898.77 kB	1.3 MB
@opentelemetry/api	1.4.1	780.32 kB	780.32 kB
import-in-the-middle	1.7.3	67.62 kB	731.01 kB
pprof-format	2.0.7	588.12 kB	588.12 kB
msgpack-lite	0.1.26	201.16 kB	281.59 kB
opentracing	0.14.7	194.81 kB	194.81 kB
semver	7.5.4	93.4 kB	123.8 kB
@datadog/sketches-js	2.1.0	109.9 kB	109.9 kB
lodash.sortby	4.7.0	75.76 kB	75.76 kB
lru-cache	7.14.0	74.95 kB	74.95 kB
ipaddr.js	2.1.0	60.23 kB	60.23 kB
ignore	5.2.4	51.22 kB	51.22 kB
int64-buffer	0.1.10	49.18 kB	49.18 kB
shell-quote	1.8.1	44.96 kB	44.96 kB
istanbul-lib-coverage	3.2.0	29.34 kB	29.34 kB
tlhunter-sorted-set	0.1.0	24.94 kB	24.94 kB
limiter	1.1.5	23.17 kB	23.17 kB
dc-polyfill	0.1.2	22.77 kB	22.77 kB
retry	0.13.1	18.85 kB	18.85 kB
node-abort-controller	3.1.1	16.89 kB	16.89 kB
jest-docblock	29.7.0	8.99 kB	12.76 kB
crypto-randomuuid	1.0.0	11.18 kB	11.18 kB
path-to-regexp	0.1.7	6.78 kB	6.78 kB
koalas	1.0.2	6.47 kB	6.47 kB
methods	1.1.2	5.29 kB	5.29 kB
module-details-from-path	1.0.3	4.47 kB	4.47 kB

_{🤖 This report was automatically generated by heaviest-objects-in-the-universe}

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3ce63fe) 85.13% compared to head (c8665ce) 75.10%.
Report is 3 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #4023       +/-   ##
===========================================
- Coverage   85.13%   75.10%   -10.04%     
===========================================
  Files         242      237        -5     
  Lines       10464    10001      -463     
  Branches       33       33               
===========================================
- Hits         8909     7511     -1398     
- Misses       1555     2490      +935     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pr-commenter]

Benchmarks

Benchmark execution time: 2024-02-05 14:10:15

Comparing candidate commit c8665ce in PR branch juan-fernandez/disable-telemetry-cypress with baseline commit 3ce63fe in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 258 metrics, 7 unstable metrics.

scenario:plugin-graphql-with-depth-on-max-18

• 🟩 max_rss_usage [-122.615MB; -100.489MB] or [-12.968%; -10.628%]

[simon-id]

little non-reg test ? to make sure it's still called when telemetry is enabled

[juan-fernandez]

little non-reg test ? to make sure it's still called when telemetry is enabled

added a test in 323e0fc

[juan-fernandez]

now the test fails in a different way 😠. Only in CI too, locally there's no problem. I'll need to dig a bit more

[juan-fernandez]

now the test fails in a different way 😠. Only in CI too, locally there's no problem. I'll need to dig a bit more

ok found the issue. It's unrelated to this PR. It was a regression I introduced in #4021. I merged the PR anyway, I probably thought the plugins were just flaking 😞