Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrading axios to squelch security scanners #4018

Closed
wants to merge 11 commits into from

Conversation

tlhunter
Copy link
Member

@tlhunter tlhunter commented Feb 1, 2024

What does this PR do?

  • upgrades a dev dependency that'll never get installed on user machines

Motivation

  • make those security scanners shut up

Issues

Currently a bunch of appsec tests fails. Seems that they're doing something special with axios that none of the other tests are doing. So far I haven't been able to figure out what it is. Here's an example of the "stacktrace", which only raises more questions:

  1) Header injection vulnerability
       with express >=4.0.0 <4.3.0 (4.0.0)
         in express
           "after all" hook for "Should not have vulnerability with CORS headers":
     TypeError: Cannot read properties of undefined (reading 'has')
      at [object Object]
      at [object Object]
      at [object Object]
      at [object Object]
      at [object Object]
      at [object Object]
      at [object Object]
      at [object Object]
      at [object Object]
      at [object Object]
      at [object Object]
      at [object Object]
      at [object Object]
      at [object Object]
      at [object Object]
      at [object Object]
      at [object Object]
      at [object Object]
      at [object Object]

The same tests pass locally:

  Header injection vulnerability
    with express >=4.0.0 <4.3.0 (4.0.0)
      in express
        ✓ Should not have vulnerability with CORS headers
MOCHA AFTER false 4.0.0
    with express >=4.3.0 (4.18.2)
      in express
        ✓ Should not have vulnerability with CORS headers
MOCHA AFTER false 4.18.2
    with express >=4.0.0 <4.3.0 (4.2.0)
      in express
        ✓ Should not have vulnerability with CORS headers
MOCHA AFTER false 4.2.0
    with express >=4.3.0 (4.3.0)
      in express
        ✓ Should not have vulnerability with CORS headers
MOCHA AFTER false 4.3.0

@tlhunter tlhunter requested a review from a team as a code owner February 1, 2024 19:55
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6bfad8f) 85.28% compared to head (889c4da) 75.35%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4018      +/-   ##
==========================================
- Coverage   85.28%   75.35%   -9.93%     
==========================================
  Files         242      242              
  Lines       10452    10461       +9     
  Branches       33       33              
==========================================
- Hits         8914     7883    -1031     
- Misses       1538     2578    +1040     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 1, 2024

Overall package size

Self size: 5.98 MB
Deduped: 62.63 MB
No deduping: 63.44 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.6.4 16.43 MB 16.44 MB
@datadog/native-appsec 7.0.0 14.51 MB 14.52 MB
@datadog/pprof 5.0.0 9.59 MB 10.44 MB
protobufjs 7.2.6 2.77 MB 7.06 MB
@datadog/native-iast-rewriter 2.2.2 2.29 MB 2.43 MB
@opentelemetry/core 1.21.0 875.84 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.7.0 1.15 MB 1.15 MB
import-in-the-middle 1.7.3 67.62 kB 768.58 kB
pprof-format 2.0.7 588.12 kB 588.12 kB
msgpack-lite 0.1.26 201.16 kB 272.06 kB
opentracing 0.14.7 194.81 kB 194.81 kB
lru-cache 7.18.3 133.92 kB 133.92 kB
semver 7.5.4 93.4 kB 123.8 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.3.1 51.46 kB 51.46 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.3 23.08 kB 23.08 kB
retry 0.13.1 18.85 kB 18.85 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Feb 1, 2024

Benchmarks

Benchmark execution time: 2024-02-03 16:28:38

Comparing candidate commit 889c4da in PR branch tlhunter/upgrade-axios with baseline commit 6bfad8f in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 257 metrics, 9 unstable metrics.

@tlhunter tlhunter requested a review from a team as a code owner February 1, 2024 20:40
Qard
Qard previously approved these changes Feb 1, 2024
@tlhunter tlhunter closed this Feb 6, 2024
@tlhunter tlhunter deleted the tlhunter/upgrade-axios branch February 7, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants