-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci-visibility] Add get known tests request #4015
Conversation
Overall package sizeSelf size: 5.97 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4015 +/- ##
==========================================
- Coverage 85.28% 85.15% -0.13%
==========================================
Files 242 243 +1
Lines 10452 10490 +38
Branches 33 33
==========================================
+ Hits 8914 8933 +19
- Misses 1538 1557 +19 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-02-01 16:26:32 Comparing candidate commit f06b528 in PR branch Found 2 performance improvements and 1 performance regressions! Performance is the same for 257 metrics, 6 unstable metrics. scenario:plugin-graphql-with-depth-off-18
scenario:plugin-graphql-with-depth-on-max-18
scenario:scope-manager-async_local_storage-18
|
cbabf92
to
ab8b91d
Compare
ab8b91d
to
75f8356
Compare
packages/dd-trace/test/ci-visibility/exporters/ci-visibility-exporter.spec.js
Outdated
Show resolved
Hide resolved
@@ -115,6 +115,18 @@ module.exports = class CiPlugin extends Plugin { | |||
}) | |||
this.telemetry.count(TELEMETRY_ITR_SKIPPED, { testLevel: 'suite' }, skippedSuites.length) | |||
}) | |||
|
|||
this.addSub(`ci:${this.constructor.id}:known-tests`, ({ onDone }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not blocking, but it's a bit difficult to know why this is needed without any publisher. Generally speaking it's a pattern that should be avoided, so just pointing it out to make sure other options were evaluated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's a good point. The changes are considerable so I split the PRs, leaving this is as a noop, which isn't great. The usage will become clear very soon though, as I have the changes ready :)
What does this PR do?
Add get known tests logic.
It's the first piece of the "Early flake detection" feature:
This PR just adds the necessary logic to request the known tests for a given test service (so the test framework can be aware of what tests are new).
Motivation
The early flake detection changes are considerable, so I'm splitting the changes in different PRs so it's easier to review.
This PR:
getKnownTests
request.getKnownTests
to the ci visibility exporter, so plugins can request known tests.This PR does not include usage of the known tests by any test framework.
Plugin Checklist
Security
Datadog employees:
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!