-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set resolved GRPC peer hostname #4013
Conversation
Overall package sizeSelf size: 5.98 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4013 +/- ##
===========================================
- Coverage 83.92% 69.19% -14.74%
===========================================
Files 107 1 -106
Lines 4330 198 -4132
Branches 33 33
===========================================
- Hits 3634 137 -3497
+ Misses 696 61 -635 ☔ View full report in Codecov by Sentry. |
ba5aa00
to
06cd0e0
Compare
BenchmarksBenchmark execution time: 2024-02-06 14:41:57 Comparing candidate commit d59464f in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 260 metrics, 6 unstable metrics. |
06cd0e0
to
40a8265
Compare
Base branch requires signed commits
What does this PR do?
In
@grpc/grpc-js
1.1.4, the previouslyUnimplementedError
-raisinggetPeer()
method was implemented correctly. This allows us to retrieve the remote IP of the GRPC server, which was previously not feasible because:getPeer
@grpc/proto-loader
.Motivation
Plugin Checklist
Additional Notes
Security
Datadog employees:
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!