Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set resolved GRPC peer hostname #4013

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Conversation

jbertran
Copy link
Contributor

@jbertran jbertran commented Jan 31, 2024

What does this PR do?

In @grpc/grpc-js 1.1.4, the previously UnimplementedError-raising getPeer() method was implemented correctly. This allows us to retrieve the remote IP of the GRPC server, which was previously not feasible because:

  • we didn't have access to the resolved IP through getPeer
  • we (still) can't use the address passed in client initialization, as it's not persisted in the client and intercepting it in the constructor is not doable for service clients loaded through @grpc/proto-loader.

Motivation

Plugin Checklist

  • Unit tests.

Additional Notes

Security

Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@jbertran jbertran requested review from a team as code owners January 31, 2024 16:09
@jbertran jbertran marked this pull request as draft January 31, 2024 16:09
Copy link

github-actions bot commented Jan 31, 2024

Overall package size

Self size: 5.98 MB
Deduped: 61.58 MB
No deduping: 62.34 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.6.4 16.43 MB 16.44 MB
@datadog/native-appsec 7.0.0 14.51 MB 14.52 MB
@datadog/pprof 5.0.0 9.59 MB 10.44 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.2.3 2.19 MB 2.28 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.7.3 67.62 kB 731.01 kB
pprof-format 2.0.7 588.12 kB 588.12 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b4f5edb) 83.92% compared to head (d59464f) 69.19%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4013       +/-   ##
===========================================
- Coverage   83.92%   69.19%   -14.74%     
===========================================
  Files         107        1      -106     
  Lines        4330      198     -4132     
  Branches       33       33               
===========================================
- Hits         3634      137     -3497     
+ Misses        696       61      -635     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbertran jbertran force-pushed the jbertran/grpc-peer-hostname branch from ba5aa00 to 06cd0e0 Compare January 31, 2024 16:33
@pr-commenter
Copy link

pr-commenter bot commented Jan 31, 2024

Benchmarks

Benchmark execution time: 2024-02-06 14:41:57

Comparing candidate commit d59464f in PR branch jbertran/grpc-peer-hostname with baseline commit b4f5edb in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 260 metrics, 6 unstable metrics.

@jbertran jbertran marked this pull request as ready for review February 1, 2024 14:58
@jbertran jbertran force-pushed the jbertran/grpc-peer-hostname branch from 06cd0e0 to 40a8265 Compare February 1, 2024 15:05
@jbertran jbertran enabled auto-merge (squash) February 6, 2024 14:44
auto-merge was automatically disabled February 6, 2024 17:02

Base branch requires signed commits

@jbertran jbertran merged commit 9e7b3ba into master Feb 7, 2024
111 checks passed
@jbertran jbertran deleted the jbertran/grpc-peer-hostname branch February 7, 2024 11:57
This was referenced Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants