Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api security enabled by default and configurable by non experimental environment variable #4005

Merged
merged 5 commits into from
Feb 6, 2024

Conversation

uurien
Copy link
Collaborator

@uurien uurien commented Jan 26, 2024

What does this PR do?

Enables API Security by default when APPSEC is enabled, and it can be disabled/enabled by DD_API_SECURITY_ENABLED env var.

Plugin Checklist

  • Unit tests.

Additional Notes

Security

Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

Copy link

github-actions bot commented Jan 26, 2024

Overall package size

Self size: 5.98 MB
Deduped: 61.58 MB
No deduping: 62.34 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.6.4 16.43 MB 16.44 MB
@datadog/native-appsec 7.0.0 14.51 MB 14.52 MB
@datadog/pprof 5.0.0 9.59 MB 10.44 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.2.3 2.19 MB 2.28 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.7.3 67.62 kB 731.01 kB
pprof-format 2.0.7 588.12 kB 588.12 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e368f4e) 85.15% compared to head (439a961) 85.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4005      +/-   ##
==========================================
+ Coverage   85.15%   85.30%   +0.14%     
==========================================
  Files         243      243              
  Lines       10504    10504              
  Branches       33       33              
==========================================
+ Hits         8945     8960      +15     
+ Misses       1559     1544      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Jan 26, 2024

Benchmarks

Benchmark execution time: 2024-02-06 09:32:12

Comparing candidate commit 439a961 in PR branch ugaitz/api-security-enabled-by-default with baseline commit e368f4e in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 259 metrics, 6 unstable metrics.

scenario:plugin-graphql-with-depth-and-collapse-on-18

  • 🟩 max_rss_usage [-125.244MB; -99.876MB] or [-13.229%; -10.550%]

@uurien uurien changed the title Api security enabled by default, sampling = 0 to disable it Api security enabled by default and add non experimental env var Jan 30, 2024
@uurien uurien marked this pull request as ready for review January 30, 2024 14:39
@uurien uurien requested a review from a team as a code owner January 30, 2024 14:39
@uurien uurien force-pushed the ugaitz/api-security-enabled-by-default branch from f487296 to faa30f7 Compare January 31, 2024 10:40
@uurien uurien force-pushed the ugaitz/api-security-enabled-by-default branch from faa30f7 to 7417e8f Compare February 2, 2024 09:08
Copy link
Member

@simon-id simon-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized, the system-tests are not even enabled for this feature, the green CI is not to be trusted

@uurien uurien force-pushed the ugaitz/api-security-enabled-by-default branch from 7417e8f to 439a961 Compare February 6, 2024 09:24
@uurien uurien changed the title Api security enabled by default and add non experimental env var Api security enabled by default and configurable by non experimental environment variable Feb 6, 2024
@uurien uurien merged commit b4f5edb into master Feb 6, 2024
111 checks passed
@uurien uurien deleted the ugaitz/api-security-enabled-by-default branch February 6, 2024 10:01
tlhunter pushed a commit that referenced this pull request Feb 12, 2024
tlhunter pushed a commit that referenced this pull request Feb 12, 2024
tlhunter pushed a commit that referenced this pull request Feb 12, 2024
This was referenced Feb 13, 2024
tlhunter pushed a commit that referenced this pull request Feb 14, 2024
tlhunter pushed a commit that referenced this pull request Feb 14, 2024
tlhunter pushed a commit that referenced this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants