-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Api security enabled by default and configurable by non experimental environment variable #4005
Conversation
Overall package sizeSelf size: 5.98 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4005 +/- ##
==========================================
+ Coverage 85.15% 85.30% +0.14%
==========================================
Files 243 243
Lines 10504 10504
Branches 33 33
==========================================
+ Hits 8945 8960 +15
+ Misses 1559 1544 -15 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-02-06 09:32:12 Comparing candidate commit 439a961 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 259 metrics, 6 unstable metrics. scenario:plugin-graphql-with-depth-and-collapse-on-18
|
f487296
to
faa30f7
Compare
faa30f7
to
7417e8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized, the system-tests are not even enabled for this feature, the green CI is not to be trusted
7417e8f
to
439a961
Compare
…NABLED environment variable (#4005)
…NABLED environment variable (#4005)
…NABLED environment variable (#4005)
…NABLED environment variable (#4005)
…NABLED environment variable (#4005)
…NABLED environment variable (#4005)
What does this PR do?
Enables API Security by default when APPSEC is enabled, and it can be disabled/enabled by
DD_API_SECURITY_ENABLED
env var.Plugin Checklist
Additional Notes
Security
Datadog employees:
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!