-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support schema extraction in express response objects #3976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overall package sizeSelf size: 6 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3976 +/- ##
==========================================
+ Coverage 85.14% 85.19% +0.04%
==========================================
Files 243 243
Lines 10504 10554 +50
Branches 33 33
==========================================
+ Hits 8944 8991 +47
- Misses 1560 1563 +3 ☔ View full report in Codecov by Sentry. |
25dafcc
to
19e4c64
Compare
19e4c64
to
81e3d68
Compare
rochdev
previously approved these changes
Feb 7, 2024
simon-id
commented
Feb 8, 2024
simon-id
commented
Feb 8, 2024
simon-id
commented
Feb 8, 2024
Co-authored-by: simon-id <[email protected]>
ok LGTM |
rochdev
approved these changes
Feb 8, 2024
CarlesDD
approved these changes
Feb 9, 2024
tlhunter
pushed a commit
that referenced
this pull request
Feb 12, 2024
--------- Co-authored-by: Ugaitz Urien <[email protected]> Co-authored-by: simon-id <[email protected]>
tlhunter
pushed a commit
that referenced
this pull request
Feb 12, 2024
--------- Co-authored-by: Ugaitz Urien <[email protected]> Co-authored-by: simon-id <[email protected]>
tlhunter
pushed a commit
that referenced
this pull request
Feb 12, 2024
--------- Co-authored-by: Ugaitz Urien <[email protected]> Co-authored-by: simon-id <[email protected]>
tlhunter
pushed a commit
that referenced
this pull request
Feb 14, 2024
--------- Co-authored-by: Ugaitz Urien <[email protected]> Co-authored-by: simon-id <[email protected]>
tlhunter
pushed a commit
that referenced
this pull request
Feb 14, 2024
--------- Co-authored-by: Ugaitz Urien <[email protected]> Co-authored-by: simon-id <[email protected]>
tlhunter
pushed a commit
that referenced
this pull request
Feb 14, 2024
--------- Co-authored-by: Ugaitz Urien <[email protected]> Co-authored-by: simon-id <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When a express response method (
send
,json
orjsonp
) is used with an object, sends the object to the waf to extract the schema and detect some sensitive values.Motivation
Supports response data in API Security
APPSEC-47094