Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support schema extraction in express response objects #3976

Merged
merged 15 commits into from
Feb 9, 2024
Merged

Conversation

simon-id
Copy link
Member

@simon-id simon-id commented Jan 18, 2024

What does this PR do?

When a express response method (send, json or jsonp) is used with an object, sends the object to the waf to extract the schema and detect some sensitive values.

Motivation

Supports response data in API Security

APPSEC-47094

Copy link

github-actions bot commented Jan 18, 2024

Overall package size

Self size: 6 MB
Deduped: 61.6 MB
No deduping: 62.36 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.6.4 16.43 MB 16.44 MB
@datadog/native-appsec 7.0.0 14.51 MB 14.52 MB
@datadog/pprof 5.0.0 9.59 MB 10.44 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.2.3 2.19 MB 2.28 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.7.3 67.62 kB 731.01 kB
pprof-format 2.0.7 588.12 kB 588.12 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9e7b3ba) 85.14% compared to head (ffd62c1) 85.19%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3976      +/-   ##
==========================================
+ Coverage   85.14%   85.19%   +0.04%     
==========================================
  Files         243      243              
  Lines       10504    10554      +50     
  Branches       33       33              
==========================================
+ Hits         8944     8991      +47     
- Misses       1560     1563       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simon-id simon-id reopened this Jan 18, 2024
@pr-commenter
Copy link

pr-commenter bot commented Jan 18, 2024

Benchmarks

Benchmark execution time: 2024-02-08 16:06:09

Comparing candidate commit ffd62c1 in PR branch express_apisec with baseline commit 9e7b3ba in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 258 metrics, 8 unstable metrics.

@uurien uurien changed the title Express apisec Support schema extraction in express response objects Feb 7, 2024
@uurien uurien self-assigned this Feb 7, 2024
@uurien uurien marked this pull request as ready for review February 7, 2024 16:34
@uurien uurien requested review from a team as code owners February 7, 2024 16:34
@uurien uurien requested a review from jbertran February 7, 2024 16:34
rochdev
rochdev previously approved these changes Feb 7, 2024
@simon-id
Copy link
Member Author

simon-id commented Feb 8, 2024

ok LGTM

@uurien uurien merged commit a589b3a into master Feb 9, 2024
108 of 111 checks passed
@uurien uurien deleted the express_apisec branch February 9, 2024 08:11
tlhunter pushed a commit that referenced this pull request Feb 12, 2024
---------

Co-authored-by: Ugaitz Urien <[email protected]>
Co-authored-by: simon-id <[email protected]>
tlhunter pushed a commit that referenced this pull request Feb 12, 2024
---------

Co-authored-by: Ugaitz Urien <[email protected]>
Co-authored-by: simon-id <[email protected]>
tlhunter pushed a commit that referenced this pull request Feb 12, 2024
---------

Co-authored-by: Ugaitz Urien <[email protected]>
Co-authored-by: simon-id <[email protected]>
This was referenced Feb 13, 2024
tlhunter pushed a commit that referenced this pull request Feb 14, 2024
---------

Co-authored-by: Ugaitz Urien <[email protected]>
Co-authored-by: simon-id <[email protected]>
tlhunter pushed a commit that referenced this pull request Feb 14, 2024
---------

Co-authored-by: Ugaitz Urien <[email protected]>
Co-authored-by: simon-id <[email protected]>
tlhunter pushed a commit that referenced this pull request Feb 14, 2024
---------

Co-authored-by: Ugaitz Urien <[email protected]>
Co-authored-by: simon-id <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants