-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix couchbase segfault. On >=3.2.0 <3.2.2 it would segfault on cluster.close() #3926
Conversation
Overall package sizeSelf size: 5.82 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3926 +/- ##
==========================================
+ Coverage 84.55% 84.69% +0.14%
==========================================
Files 236 238 +2
Lines 9981 10156 +175
Branches 33 33
==========================================
+ Hits 8439 8602 +163
- Misses 1542 1554 +12 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-01-04 12:22:50 Comparing candidate commit 26c92a9 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 259 metrics, 6 unstable metrics. scenario:plugin-graphql-with-depth-and-collapse-on-18
|
0f1dad5
to
d95891e
Compare
677e9d5
to
1d0ee95
Compare
1d0ee95
to
441a1f3
Compare
441a1f3
to
26c92a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice find 👏
What does this PR do?
Fixes the segfault issue with the couchbase tests. Turns out the >=3.2.0 <3.2.2 releases are actually just broken. They segfault when the cluster connection closes, even without our instrumentation.
See: https://issues.couchbase.com/browse/JSCBC-936
Motivation
Couchbase randomly segfaulting makes the tests kind of useless. CI should be green.
Security
Datadog employees:
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!