Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix couchbase segfault. On >=3.2.0 <3.2.2 it would segfault on cluster.close() #3926

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

Qard
Copy link
Contributor

@Qard Qard commented Jan 4, 2024

What does this PR do?

Fixes the segfault issue with the couchbase tests. Turns out the >=3.2.0 <3.2.2 releases are actually just broken. They segfault when the cluster connection closes, even without our instrumentation.

See: https://issues.couchbase.com/browse/JSCBC-936

Motivation

Couchbase randomly segfaulting makes the tests kind of useless. CI should be green.

Security

Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@Qard Qard added bug Something isn't working integration-couchbase labels Jan 4, 2024
Copy link

github-actions bot commented Jan 4, 2024

Overall package size

Self size: 5.82 MB
Deduped: 61.24 MB
No deduping: 62 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.6.4 16.43 MB 16.44 MB
@datadog/native-appsec 6.0.0 14.48 MB 14.48 MB
@datadog/pprof 4.1.0 9.36 MB 10.21 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.2.2 2.29 MB 2.37 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.4.2 41.4 kB 704.79 kB
pprof-format 2.0.7 588.12 kB 588.12 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.2 22.77 kB 22.77 kB
retry 0.13.1 18.85 kB 18.85 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9e5b158) 84.55% compared to head (26c92a9) 84.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3926      +/-   ##
==========================================
+ Coverage   84.55%   84.69%   +0.14%     
==========================================
  Files         236      238       +2     
  Lines        9981    10156     +175     
  Branches       33       33              
==========================================
+ Hits         8439     8602     +163     
- Misses       1542     1554      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Jan 4, 2024

Benchmarks

Benchmark execution time: 2024-01-04 12:22:50

Comparing candidate commit 26c92a9 in PR branch fix-couchbase-segfault with baseline commit 9e5b158 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 259 metrics, 6 unstable metrics.

scenario:plugin-graphql-with-depth-and-collapse-on-18

  • 🟩 max_rss_usage [-120.091MB; -110.505MB] or [-12.678%; -11.666%]

@Qard Qard force-pushed the fix-couchbase-segfault branch from 0f1dad5 to d95891e Compare January 4, 2024 10:01
@Qard Qard force-pushed the fix-couchbase-segfault branch 12 times, most recently from 677e9d5 to 1d0ee95 Compare January 4, 2024 11:49
@Qard Qard changed the title wip Fix couchbase segfault. On >=3.2.0 <3.2.2 it would segfault on cluster.close() Jan 4, 2024
@Qard Qard marked this pull request as ready for review January 4, 2024 11:56
@Qard Qard requested review from a team as code owners January 4, 2024 11:56
@Qard Qard requested a review from jbertran January 4, 2024 11:56
@Qard Qard force-pushed the fix-couchbase-segfault branch from 1d0ee95 to 441a1f3 Compare January 4, 2024 12:11
@Qard Qard force-pushed the fix-couchbase-segfault branch from 441a1f3 to 26c92a9 Compare January 4, 2024 12:13
Copy link
Collaborator

@juan-fernandez juan-fernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find 👏

@Qard Qard merged commit 0f3b143 into master Jan 4, 2024
108 of 109 checks passed
@Qard Qard deleted the fix-couchbase-segfault branch January 4, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants