Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci-visibility] Fix slowness in test-environment.spec.js #3923

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

juan-fernandez
Copy link
Collaborator

@juan-fernandez juan-fernandez commented Jan 3, 2024

What does this PR do?

Fix slowness in tracing tests.

Motivation

After #3752, stubbing sanitizedExec within git.js did nothing: this produced that the tests in packages/dd-trace/test/plugins/util/test-environment.spec.js were actually executing execFileSync, slowing them down significantly.

@juan-fernandez juan-fernandez changed the title speed up test by stubbing [ci-visibility] Fix slowness in test-environment.spec.js Jan 3, 2024
@juan-fernandez juan-fernandez marked this pull request as ready for review January 3, 2024 11:04
@juan-fernandez juan-fernandez requested a review from a team as a code owner January 3, 2024 11:04
Copy link

github-actions bot commented Jan 3, 2024

Overall package size

Self size: 5.82 MB
Deduped: 61.24 MB
No deduping: 62 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.6.4 16.43 MB 16.44 MB
@datadog/native-appsec 6.0.0 14.48 MB 14.48 MB
@datadog/pprof 4.1.0 9.36 MB 10.21 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.2.2 2.29 MB 2.37 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.4.2 41.4 kB 704.79 kB
pprof-format 2.0.7 588.12 kB 588.12 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.2 22.77 kB 22.77 kB
retry 0.13.1 18.85 kB 18.85 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e8df0fa) 84.55% compared to head (e9456e5) 84.55%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3923   +/-   ##
=======================================
  Coverage   84.55%   84.55%           
=======================================
  Files         235      235           
  Lines        9972     9972           
  Branches       33       33           
=======================================
  Hits         8432     8432           
  Misses       1540     1540           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Jan 3, 2024

Benchmarks

Benchmark execution time: 2024-01-03 11:13:32

Comparing candidate commit e9456e5 in PR branch juan-fernandez/speed-up-test-env-test with baseline commit e8df0fa in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 520 metrics, 12 unstable metrics.

@Qard Qard merged commit e2df7ec into master Jan 3, 2024
111 of 112 checks passed
@Qard Qard deleted the juan-fernandez/speed-up-test-env-test branch January 3, 2024 11:15
khanayan123 pushed a commit that referenced this pull request Jan 4, 2024
khanayan123 pushed a commit that referenced this pull request Jan 4, 2024
khanayan123 pushed a commit that referenced this pull request Jan 4, 2024
khanayan123 pushed a commit that referenced this pull request Jan 4, 2024
khanayan123 pushed a commit that referenced this pull request Jan 4, 2024
khanayan123 pushed a commit that referenced this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants