-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci-visibility] Fix slowness in test-environment.spec.js
#3923
Conversation
test-environment.spec.js
Overall package sizeSelf size: 5.82 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3923 +/- ##
=======================================
Coverage 84.55% 84.55%
=======================================
Files 235 235
Lines 9972 9972
Branches 33 33
=======================================
Hits 8432 8432
Misses 1540 1540 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-01-03 11:13:32 Comparing candidate commit e9456e5 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 520 metrics, 12 unstable metrics. |
What does this PR do?
Fix slowness in tracing tests.
Motivation
After #3752, stubbing
sanitizedExec
withingit.js
did nothing: this produced that the tests inpackages/dd-trace/test/plugins/util/test-environment.spec.js
were actually executingexecFileSync
, slowing them down significantly.