Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci-visibility] Fix cucumber plugin tests for node<16 #3902

Merged
merged 2 commits into from
Dec 22, 2023

Conversation

juan-fernandez
Copy link
Collaborator

What does this PR do?

Node<16 is no longer supported for cucumber, so we have to skip the tests.

Motivation

Fix CI.

Plugin Checklist

  • Unit tests.

@juan-fernandez juan-fernandez marked this pull request as ready for review December 22, 2023 14:20
@juan-fernandez juan-fernandez requested a review from a team as a code owner December 22, 2023 14:20
Copy link

github-actions bot commented Dec 22, 2023

Overall package size

Self size: 5.81 MB
Deduped: 61.23 MB
No deduping: 61.99 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.6.4 16.43 MB 16.44 MB
@datadog/native-appsec 6.0.0 14.48 MB 14.48 MB
@datadog/pprof 4.1.0 9.36 MB 10.21 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.2.2 2.29 MB 2.37 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.4.2 41.4 kB 704.79 kB
pprof-format 2.0.7 588.12 kB 588.12 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.2 22.77 kB 22.77 kB
retry 0.13.1 18.85 kB 18.85 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (03f1a68) 84.73% compared to head (448d068) 84.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3902   +/-   ##
=======================================
  Coverage   84.73%   84.73%           
=======================================
  Files         237      237           
  Lines       10132    10132           
  Branches       33       33           
=======================================
  Hits         8585     8585           
  Misses       1547     1547           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Dec 22, 2023

Benchmarks

Benchmark execution time: 2023-12-22 14:45:26

Comparing candidate commit 448d068 in PR branch juan-fernandez/fix-cucumber-plugin-tests with baseline commit 03f1a68 in branch master.

Found 1 performance improvements and 1 performance regressions! Performance is the same for 519 metrics, 11 unstable metrics.

scenario:plugin-graphql-with-depth-off-18

  • 🟩 max_rss_usage [-146.128MB; -66.036MB] or [-15.112%; -6.829%]

scenario:plugin-q-with-tracer-16

  • 🟥 instructions [+136.3M instructions; +194.9M instructions] or [+8.132%; +11.631%]

@juan-fernandez juan-fernandez merged commit a9c1020 into master Dec 22, 2023
107 of 109 checks passed
@juan-fernandez juan-fernandez deleted the juan-fernandez/fix-cucumber-plugin-tests branch December 22, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants