Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer service mapping #3320

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Peer service mapping #3320

merged 1 commit into from
Jul 12, 2023

Conversation

jbertran
Copy link
Contributor

What does this PR do?

Expose DD_TRACE_PEER_SERVICE_MAPPING, which behaves like DD_SERVICE_MAPPING, but for the peer.service tag.

If the mapping is matched, the original value is reported in _dd.peer.service.remapped_from.

Motivation

Plugin Checklist

  • Unit tests.

Additional Notes

@github-actions
Copy link

github-actions bot commented Jun 30, 2023

Overall package size

Self size: 4.8 MB
Deduped: 57.79 MB
No deduping: 57.88 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.5.0 14.86 MB 14.86 MB
@datadog/native-appsec 3.2.0 13.38 MB 13.39 MB
@datadog/pprof 3.0.0 10.54 MB 11.39 MB
protobufjs 7.2.4 2.74 MB 6.52 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.3 93.39 kB 123.79 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.5 34.34 kB 38.81 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Jun 30, 2023

Benchmarks

Benchmark execution time: 2023-07-10 14:47:18

Comparing candidate commit 4a99565 in PR branch jbertran/peer-service-remapping with baseline commit d00a4e0 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 469 metrics, 23 unstable metrics.

@jbertran jbertran force-pushed the jbertran/peer-service-remapping branch 3 times, most recently from 8ba783e to 54e897e Compare June 30, 2023 15:12
@jbertran jbertran marked this pull request as ready for review June 30, 2023 15:12
@jbertran jbertran requested a review from a team as a code owner June 30, 2023 15:12
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #3320 (4a99565) into master (d00a4e0) will increase coverage by 0.09%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master    #3320      +/-   ##
==========================================
+ Coverage   84.11%   84.21%   +0.09%     
==========================================
  Files         204      204              
  Lines        8015     8020       +5     
  Branches       33       33              
==========================================
+ Hits         6742     6754      +12     
+ Misses       1273     1266       -7     
Impacted Files Coverage Δ
packages/dd-trace/src/constants.js 100.00% <ø> (ø)
packages/dd-trace/src/plugins/outbound.js 72.41% <80.00%> (+25.98%) ⬆️
packages/dd-trace/src/config.js 99.09% <100.00%> (+0.01%) ⬆️
packages/dd-trace/src/opentracing/tracer.js 98.52% <100.00%> (+0.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jbertran jbertran marked this pull request as draft June 30, 2023 15:31
@jbertran jbertran force-pushed the jbertran/peer-service-remapping branch 6 times, most recently from 188d745 to bec2e9a Compare July 6, 2023 09:09
@amarziali amarziali marked this pull request as ready for review July 6, 2023 14:44
@amarziali amarziali marked this pull request as draft July 6, 2023 14:44
@jbertran jbertran force-pushed the jbertran/peer-service-remapping branch 3 times, most recently from c02984e to 3dd7fb1 Compare July 10, 2023 11:20
@jbertran jbertran marked this pull request as ready for review July 10, 2023 11:21
@jbertran jbertran force-pushed the jbertran/peer-service-remapping branch 2 times, most recently from 3a98f56 to 689b4d0 Compare July 10, 2023 14:29
Supplying a `DD_TRACE_PEER_SERVICE_MAPPING` allows users to modify the `peer.service` tag
in the same manner that `DD_SERVICE_MAPPING` does for service name.

If the `peer.service` value was matched by the mapping, the original value of the tag before
remapping is reported in `_dd.peer.service.remapped_from`.
@jbertran jbertran force-pushed the jbertran/peer-service-remapping branch from 689b4d0 to 4a99565 Compare July 10, 2023 14:38
@tlhunter tlhunter self-requested a review July 11, 2023 17:00
@tlhunter
Copy link
Member

Can you also add this new environment variable to the documentation repo:
https://github.com/DataDog/documentation/blob/master/content/en/tracing/trace_collection/library_config/nodejs.md

Is this variable a standard across tracers? Such as Python?

@tlhunter tlhunter merged commit ea81490 into master Jul 12, 2023
Qard pushed a commit that referenced this pull request Jul 13, 2023
Supplying a `DD_TRACE_PEER_SERVICE_MAPPING` allows users to modify the `peer.service` tag
in the same manner that `DD_SERVICE_MAPPING` does for service name.

If the `peer.service` value was matched by the mapping, the original value of the tag before
remapping is reported in `_dd.peer.service.remapped_from`.
Qard pushed a commit that referenced this pull request Jul 13, 2023
Supplying a `DD_TRACE_PEER_SERVICE_MAPPING` allows users to modify the `peer.service` tag
in the same manner that `DD_SERVICE_MAPPING` does for service name.

If the `peer.service` value was matched by the mapping, the original value of the tag before
remapping is reported in `_dd.peer.service.remapped_from`.
Qard pushed a commit that referenced this pull request Jul 13, 2023
Supplying a `DD_TRACE_PEER_SERVICE_MAPPING` allows users to modify the `peer.service` tag
in the same manner that `DD_SERVICE_MAPPING` does for service name.

If the `peer.service` value was matched by the mapping, the original value of the tag before
remapping is reported in `_dd.peer.service.remapped_from`.
Qard pushed a commit that referenced this pull request Jul 14, 2023
Supplying a `DD_TRACE_PEER_SERVICE_MAPPING` allows users to modify the `peer.service` tag
in the same manner that `DD_SERVICE_MAPPING` does for service name.

If the `peer.service` value was matched by the mapping, the original value of the tag before
remapping is reported in `_dd.peer.service.remapped_from`.
Qard pushed a commit that referenced this pull request Jul 14, 2023
Supplying a `DD_TRACE_PEER_SERVICE_MAPPING` allows users to modify the `peer.service` tag
in the same manner that `DD_SERVICE_MAPPING` does for service name.

If the `peer.service` value was matched by the mapping, the original value of the tag before
remapping is reported in `_dd.peer.service.remapped_from`.
Qard pushed a commit that referenced this pull request Jul 14, 2023
Supplying a `DD_TRACE_PEER_SERVICE_MAPPING` allows users to modify the `peer.service` tag
in the same manner that `DD_SERVICE_MAPPING` does for service name.

If the `peer.service` value was matched by the mapping, the original value of the tag before
remapping is reported in `_dd.peer.service.remapped_from`.
@tlhunter tlhunter deleted the jbertran/peer-service-remapping branch January 19, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants