-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-instrument @opentelemetry/sdk-trace-node #3248
Conversation
Overall package sizeSelf size: 4.36 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
|
||
get TracerProvider () { | ||
return require('../opentelemetry/tracer_provider') | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra bug fix to allow accessing TracerProvider
before doing tracer.init(...)
.
Codecov Report
@@ Coverage Diff @@
## master #3248 +/- ##
==========================================
+ Coverage 86.01% 86.04% +0.02%
==========================================
Files 194 194
Lines 7517 7518 +1
Branches 33 33
==========================================
+ Hits 6466 6469 +3
+ Misses 1051 1049 -2
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -62,7 +62,7 @@ class ContextManager { | |||
bind (context, target) { | |||
const self = this | |||
return function (...args) { | |||
return self.with(context, target, this, args) | |||
return self.with(context, target, this, ...args) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And another bug fix to ensure arguments are passed through bind properly.
5b7e29c
to
7b208e6
Compare
7b208e6
to
bf352d9
Compare
What does this PR do?
Auto-instrument
@opentelemetry/sdk-trace-node
whenDD_TRACE_OTEL_ENABLED
is setMotivation
We want to be able to enable our SDK with zero code changes.
Fixes #3240