-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No HttpOnly vulnerability detection #3228
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overall package sizeSelf size: 4.33 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3228 +/- ##
==========================================
+ Coverage 84.74% 86.00% +1.25%
==========================================
Files 197 193 -4
Lines 8075 7493 -582
Branches 133 33 -100
==========================================
- Hits 6843 6444 -399
+ Misses 1232 1049 -183
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
iunanua
reviewed
Jun 12, 2023
c05810c
to
32223bc
Compare
0a3e26a
to
a92731c
Compare
CarlesDD
reviewed
Jun 14, 2023
5f8ac10
to
6f4a2cd
Compare
6f4a2cd
to
07b3cef
Compare
07b3cef
to
683dd20
Compare
iunanua
approved these changes
Jun 15, 2023
CarlesDD
approved these changes
Jun 15, 2023
nsavoire
pushed a commit
that referenced
this pull request
Jun 20, 2023
nsavoire
pushed a commit
that referenced
this pull request
Jun 20, 2023
nsavoire
pushed a commit
that referenced
this pull request
Jun 21, 2023
This was referenced Jun 21, 2023
Merged
Merged
Merged
tlhunter
pushed a commit
that referenced
this pull request
Jun 23, 2023
tlhunter
pushed a commit
that referenced
this pull request
Jun 23, 2023
tlhunter
pushed a commit
that referenced
this pull request
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It detects a vulnerability when HttpOnly flag is not set in a
set-cookie
header.To improve the vulnerability detection algorithm in cookies, when in the same
set-cookie
header call are multiple cookies related vulnerabilities, the location will be calculated only once, at this way we will only expend 1 of our context operations and we will be able to detect more vulnerabilities with the same budget.Plugin Checklist