Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add external log writer #3201

Merged
merged 16 commits into from
Jun 15, 2023
Merged

add external log writer #3201

merged 16 commits into from
Jun 15, 2023

Conversation

crysmags
Copy link
Collaborator

@crysmags crysmags commented May 30, 2023

What does this PR do?

  • This PR is to add Config support for sending logs to Datadog

Motivation

  • the first intended use-case is for the OpenAI integration

Plugin Checklist

Additional Notes

@crysmags crysmags requested a review from a team as a code owner May 30, 2023 17:10
@github-actions
Copy link

github-actions bot commented May 30, 2023

Overall package size

Self size: 4.35 MB
Deduped: 60.71 MB
No deduping: 60.75 MB

Dependency sizes

name version self size total size
@datadog/pprof 2.2.1 14.24 MB 15.12 MB
@datadog/native-iast-taint-tracking 1.5.0 14.86 MB 14.86 MB
@datadog/native-appsec 3.2.0 13.38 MB 13.39 MB
protobufjs 7.1.2 2.76 MB 6.55 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
@opentelemetry/core 1.3.1 784.66 kB 1.37 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.3.8 88.2 kB 118.6 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.5 34.34 kB 38.81 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #3201 (62e7eec) into master (ae09226) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3201      +/-   ##
==========================================
+ Coverage   85.97%   86.02%   +0.04%     
==========================================
  Files         194      194              
  Lines        7510     7514       +4     
  Branches       33       33              
==========================================
+ Hits         6457     6464       +7     
+ Misses       1053     1050       -3     
Impacted Files Coverage Δ
packages/dd-trace/src/config.js 99.03% <100.00%> (+0.01%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pr-commenter
Copy link

pr-commenter bot commented May 30, 2023

Benchmarks

Comparing candidate commit 62e7eec in PR branch openAi_logger with baseline commit ae09226 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 444 metrics, 28 unstable metrics.

@tlhunter
Copy link
Member

Can you add a test for the logger?

I think the best way to test it would be to use the nock package. There is a bunch of examples in dd-trace already of how to use it. Basically it takes a URL to intercept, and can trigger some expect() calls to ensure the log body that is sent adheres to the expected shape.

@tlhunter tlhunter changed the title Adding Open Ai logger add external logger Jun 2, 2023
@tlhunter tlhunter changed the title add external logger add external log writer Jun 2, 2023
This file has moved to packages/dd-trace/src/external-logger/src/index.js
Qard
Qard previously approved these changes Jun 15, 2023
Copy link
Contributor

@Qard Qard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM with some minor suggested improvements.

@tlhunter tlhunter merged commit 357d1ed into master Jun 15, 2023
@tlhunter tlhunter deleted the openAi_logger branch June 15, 2023 21:17
nsavoire pushed a commit that referenced this pull request Jun 20, 2023

---------

Co-authored-by: Thomas Hunter II <[email protected]>
nsavoire pushed a commit that referenced this pull request Jun 20, 2023

---------

Co-authored-by: Thomas Hunter II <[email protected]>
nsavoire pushed a commit that referenced this pull request Jun 21, 2023

---------

Co-authored-by: Thomas Hunter II <[email protected]>
This was referenced Jun 21, 2023
tlhunter added a commit that referenced this pull request Jun 23, 2023

---------

Co-authored-by: Thomas Hunter II <[email protected]>
tlhunter added a commit that referenced this pull request Jun 23, 2023

---------

Co-authored-by: Thomas Hunter II <[email protected]>
tlhunter added a commit that referenced this pull request Jun 23, 2023

---------

Co-authored-by: Thomas Hunter II <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants