Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Taint cookies and headers (#3182)" #3192

Merged
merged 1 commit into from
May 26, 2023

Conversation

CarlesDD
Copy link
Contributor

This reverts commit cc51732.

What does this PR do?

Revert #3182

Motivation

#3182 seems to increment the cpu and memory consumption when IAST is enabled. Reverting until we figure out what's wrong with it.

@github-actions
Copy link

Overall package size

Self size: 4.18 MB
Deduped: 58.38 MB
No deduping: 58.43 MB

Dependency sizes

name version self size total size
@datadog/pprof 2.2.1 14.24 MB 15.12 MB
@datadog/native-iast-taint-tracking 1.4.1 14.85 MB 14.86 MB
@datadog/native-appsec 3.2.0 13.38 MB 13.39 MB
protobufjs 7.1.2 2.76 MB 6.55 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.3.8 88.2 kB 118.6 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.5 34.34 kB 38.81 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #3192 (727ad53) into master (e8ed531) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3192      +/-   ##
==========================================
+ Coverage   86.55%   86.57%   +0.01%     
==========================================
  Files         333      333              
  Lines       11947    11934      -13     
  Branches       33       33              
==========================================
- Hits        10341    10332       -9     
+ Misses       1606     1602       -4     
Impacted Files Coverage Δ
...s/dd-trace/src/appsec/iast/taint-tracking/index.js 100.00% <ø> (ø)
...ace/src/appsec/iast/taint-tracking/origin-types.js 100.00% <ø> (ø)
packages/dd-trace/src/appsec/iast/index.js 100.00% <100.00%> (ø)
...trace/src/appsec/iast/taint-tracking/operations.js 100.00% <100.00%> (+1.58%) ⬆️
.../dd-trace/src/appsec/iast/taint-tracking/plugin.js 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@CarlesDD CarlesDD marked this pull request as ready for review May 26, 2023 14:22
@CarlesDD CarlesDD requested review from a team as code owners May 26, 2023 14:22
@CarlesDD CarlesDD merged commit d638b4b into master May 26, 2023
thedavl pushed a commit that referenced this pull request May 30, 2023
uurien pushed a commit that referenced this pull request Jun 1, 2023
uurien pushed a commit that referenced this pull request Jun 1, 2023
uurien pushed a commit that referenced this pull request Jun 1, 2023
uurien pushed a commit that referenced this pull request Jun 2, 2023
uurien pushed a commit that referenced this pull request Jun 2, 2023
uurien pushed a commit that referenced this pull request Jun 2, 2023
@tlhunter tlhunter deleted the ccapell/revert-taint-cookies-headers branch January 19, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants