-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci-visibility] Test skipping logic for cypress #3167
Conversation
Overall package sizeSelf size: 4.19 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3167 +/- ##
==========================================
+ Coverage 86.54% 87.71% +1.16%
==========================================
Files 333 247 -86
Lines 11895 9141 -2754
Branches 33 33
==========================================
- Hits 10295 8018 -2277
+ Misses 1600 1123 -477
... and 95 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
8e234ac
to
34ecedc
Compare
a448176
to
bf428e3
Compare
package.json
Outdated
"test:integration:cucumber": "mocha --colors --timeout 30000 \"integration-tests/cucumber/*.spec.js\"", | ||
"test:integration:cypress": "mocha --colors --timeout 30000 \"integration-tests/cypress/*.spec.js\"", | ||
"test:integration:playwright": "mocha --colors --timeout 30000 \"integration-tests/playwright/*.spec.js\"", | ||
"test:integration:cucumber": "mocha --colors --timeout 30000 --exit \"integration-tests/cucumber/*.spec.js\"", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed? Needing this means the test isn't exiting properly and Mocha needs to kill it. Not only is this working around the issue, it won't be compatible with tap.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah there was some kind of weird race condition where if the test ended before the cypress process was finished, a handle was kept alive, not allowing the process to finish. I can't explain it but this change seems to fix it
What does this PR do?
Add ITR logic to cypress.
Motivation
Allow cypress users to use ITR.