Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot read properties of undefined (reading 'timeout') #3939

Closed
ar-naturalint opened this issue Jan 8, 2024 · 4 comments
Closed

Cannot read properties of undefined (reading 'timeout') #3939

ar-naturalint opened this issue Jan 8, 2024 · 4 comments
Labels
bug Something isn't working integration-http

Comments

@ar-naturalint
Copy link

need to check that options exists

uncaughtException: Cannot read properties of undefined (reading 'timeout')
TypeError: Cannot read properties of undefined (reading 'timeout')
    at HttpClientPlugin.error (/app/node_modules/dd-trace/packages/datadog-plugin-http/src/client.js:125:39)
    at /app/node_modules/dd-trace/packages/dd-trace/src/plugins/tracing.js:73:22

if (!args.options.agent?.options.timeout && !customRequestTimeout) return

@resteinbock
Copy link

We cannot use https://github.com/DataDog/dd-trace-js/releases/tag/v4.23.0 because of this issue

@atif-saddique-deel
Copy link
Contributor

any update on this? we are also having this from time to time.

atif-saddique-deel added a commit to atif-saddique-deel/dd-trace-js that referenced this issue Feb 2, 2024
When options are undefined, doing `options.timeout` throws error and crash the whole node process.
DataDog#3939
simon-id pushed a commit that referenced this issue Feb 5, 2024
When options are undefined, doing `options.timeout` throws error and crash the whole node process.
#3939
@simon-id
Copy link
Member

simon-id commented Feb 5, 2024

Fixed in #4029
I'l update the issue once it's released.

simon-id added a commit that referenced this issue Feb 5, 2024
When options are undefined, doing `options.timeout` throws error and crash the whole node process.
#3939

Co-authored-by: Atif Saddique <[email protected]>
@tlhunter tlhunter added bug Something isn't working integration-http labels Feb 9, 2024
tlhunter pushed a commit that referenced this issue Feb 12, 2024
When options are undefined, doing `options.timeout` throws error and crash the whole node process.
#3939

Co-authored-by: Atif Saddique <[email protected]>
tlhunter pushed a commit that referenced this issue Feb 12, 2024
When options are undefined, doing `options.timeout` throws error and crash the whole node process.
#3939

Co-authored-by: Atif Saddique <[email protected]>
tlhunter pushed a commit that referenced this issue Feb 12, 2024
When options are undefined, doing `options.timeout` throws error and crash the whole node process.
#3939

Co-authored-by: Atif Saddique <[email protected]>
tlhunter pushed a commit that referenced this issue Feb 14, 2024
When options are undefined, doing `options.timeout` throws error and crash the whole node process.
#3939

Co-authored-by: Atif Saddique <[email protected]>
tlhunter pushed a commit that referenced this issue Feb 14, 2024
When options are undefined, doing `options.timeout` throws error and crash the whole node process.
#3939

Co-authored-by: Atif Saddique <[email protected]>
tlhunter pushed a commit that referenced this issue Feb 14, 2024
When options are undefined, doing `options.timeout` throws error and crash the whole node process.
#3939

Co-authored-by: Atif Saddique <[email protected]>
@simon-id
Copy link
Member

The fix has been released in versions 5.3.0 / 4.27.0 / 3.48.0 of dd-trace 👍 Thank you @atif-saddique-deel for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working integration-http
Projects
None yet
Development

No branches or pull requests

5 participants