add v1 tests to cache integrations

DataDog · Apr 27, 2023 · aeeefde · aeeefde
1 parent 825ffe7
commit aeeefde
Show file tree

Hide file tree

Showing 4 changed files with 46 additions and 0 deletions.
diff --git a/packages/datadog-plugin-ioredis/test/index.spec.js b/packages/datadog-plugin-ioredis/test/index.spec.js
@@ -4,6 +4,7 @@ const agent = require('../../dd-trace/test/plugins/agent')
 const { breakThen, unbreakThen } = require('../../dd-trace/test/plugins/helpers')
 const { ERROR_MESSAGE, ERROR_TYPE, ERROR_STACK } = require('../../dd-trace/src/constants')
 
+const Nomenclature = require('../../dd-trace/src/service-naming')
 const namingSchema = require('./naming')
 
 describe('Plugin', () => {
@@ -105,6 +106,12 @@ describe('Plugin', () => {
 
           redis.get('foo').catch(done)
         })
+
+        withNamingSchema(
+          done => redis.get('foo').catch(done),
+          () => namingSchema.outbound.opName,
+          () => namingSchema.outbound.serviceName
+        )
       })
 
       describe('with configuration', () => {
@@ -137,6 +144,15 @@ describe('Plugin', () => {
 
           redis.get('foo').catch(done)
         })
+
+        withNamingSchema(
+          done => redis.get('foo').catch(done),
+          () => namingSchema.outbound.opName,
+          () => {
+            if (Nomenclature.version === 'v0') return 'custom-test'
+            return 'custom'
+          }
+        )
       })
 
       describe('with legacy configuration', () => {

diff --git a/packages/datadog-plugin-memcached/test/index.spec.js b/packages/datadog-plugin-memcached/test/index.spec.js
@@ -143,6 +143,12 @@ describe('Plugin', () => {
             done()
           }
         })
+
+        withNamingSchema(
+          done => memcached.get('test', err => err && done(err)),
+          () => namingSchema.outbound.opName,
+          () => namingSchema.outbound.serviceName
+        )
       })
 
       describe('with configuration', () => {

diff --git a/packages/datadog-plugin-redis/test/client.spec.js b/packages/datadog-plugin-redis/test/client.spec.js
@@ -94,6 +94,12 @@ describe('Plugin', () => {
           await client.get('foo')
           await promise
         })
+
+        withNamingSchema(
+          async () => client.get('foo'),
+          () => namingSchema.outbound.opName,
+          () => namingSchema.outbound.serviceName
+        )
       })
 
       describe('with configuration', () => {
@@ -136,6 +142,12 @@ describe('Plugin', () => {
           await client.get('foo')
           await promise
         })
+
+        withNamingSchema(
+          async () => client.get('foo'),
+          () => namingSchema.outbound.opName,
+          () => 'custom'
+        )
       })
 
       describe('with blocklist', () => {

diff --git a/packages/datadog-plugin-redis/test/legacy.spec.js b/packages/datadog-plugin-redis/test/legacy.spec.js
@@ -137,6 +137,12 @@ describe('Legacy Plugin', () => {
             assertError()
           })
         })
+
+        withNamingSchema(
+          () => client.get('foo', () => {}),
+          () => namingSchema.outbound.opName,
+          () => namingSchema.outbound.serviceName
+        )
       })
 
       describe('with configuration', () => {
@@ -179,6 +185,12 @@ describe('Legacy Plugin', () => {
 
           client.get('foo', () => {})
         })
+
+        withNamingSchema(
+          () => client.get('foo', () => {}),
+          () => namingSchema.outbound.opName,
+          () => 'custom'
+        )
       })
 
       describe('with legacy configuration', () => {