don't compute service name unless necessary

DataDog · May 16, 2023 · 7a93311 · 7a93311
1 parent 3717598
commit 7a93311
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/packages/dd-trace/src/plugins/consumer.js b/packages/dd-trace/src/plugins/consumer.js
@@ -8,15 +8,12 @@ class ConsumerPlugin extends InboundPlugin {
   static get type () { return 'messaging' }
 
   startSpan (options) {
-    const spanDefaults = {
-      service: this.config.service || this.serviceName(),
-      kind: this.constructor.kind
+    if (!options.service) {
+      options.service = this.config.service || this.serviceName()
+    }
+    if (!options.kind) {
+      options.kind = this.constructor.kind
     }
-    Object.keys(spanDefaults).forEach(
-      key => {
-        if (!options[key]) options[key] = spanDefaults[key]
-      }
-    )
     return super.startSpan(this.operationName(), options)
   }
 }

diff --git a/packages/dd-trace/src/plugins/producer.js b/packages/dd-trace/src/plugins/producer.js
@@ -9,9 +9,11 @@ class ProducerPlugin extends OutboundPlugin {
 
   startSpan (options) {
     const spanDefaults = {
-      service: this.config.service || this.serviceName(),
       kind: this.constructor.kind
     }
+    if (!options.service) {
+      options.service = this.config.service || this.serviceName()
+    }
     Object.keys(spanDefaults).forEach(
       key => {
         if (!options[key]) options[key] = spanDefaults[key]