Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old unused code #8343

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Remove old unused code #8343

merged 1 commit into from
Feb 6, 2025

Conversation

jbachorik
Copy link
Contributor

What Does This Do

This is a cleanup of old, unused code related to no longer active concepts of checkpoints, per-span-trace and auxiliary profilers.

Motivation

Code hygiene - avoid bit rotting unused code.

Additional Notes

Contributor Checklist

@jbachorik jbachorik added tag: no release notes Changes to exclude from release notes comp: profiling Profiling type: task labels Feb 5, 2025
@pr-commenter
Copy link

pr-commenter bot commented Feb 5, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jb/old_code_cleanup
git_commit_date 1738775023 1738777786
git_commit_sha 88f59f8 d3c54a2
release_version 1.47.0-SNAPSHOT~88f59f8817 1.47.0-SNAPSHOT~d3c54a213e
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1738780413 1738780413
ci_job_id 795836733 795836733
ci_pipeline_id 55012587 55012587
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-9e4gtdsb-project-304-concurrent-0-b177oec2 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-9e4gtdsb-project-304-concurrent-0-b177oec2 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~d3c54a213e, baseline=1.47.0-SNAPSHOT~88f59f8817

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.043 s) : 0, 1043317
Total [baseline] (10.456 s) : 0, 10455788
Agent [candidate] (1.045 s) : 0, 1045054
Total [candidate] (10.591 s) : 0, 10590725
section appsec
Agent [baseline] (1.188 s) : 0, 1188473
Total [baseline] (10.761 s) : 0, 10760653
Agent [candidate] (1.188 s) : 0, 1188091
Total [candidate] (10.723 s) : 0, 10722779
section iast
Agent [baseline] (1.175 s) : 0, 1174550
Total [baseline] (10.964 s) : 0, 10964348
Agent [candidate] (1.18 s) : 0, 1180129
Total [candidate] (11.056 s) : 0, 11055894
section profiling
Agent [baseline] (1.264 s) : 0, 1263856
Total [baseline] (10.863 s) : 0, 10862530
Agent [candidate] (1.263 s) : 0, 1263276
Total [candidate] (10.839 s) : 0, 10838525
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.043 s -
Agent appsec 1.188 s 145.156 ms (13.9%)
Agent iast 1.175 s 131.233 ms (12.6%)
Agent profiling 1.264 s 220.54 ms (21.1%)
Total tracing 10.456 s -
Total appsec 10.761 s 304.865 ms (2.9%)
Total iast 10.964 s 508.561 ms (4.9%)
Total profiling 10.863 s 406.742 ms (3.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.045 s -
Agent appsec 1.188 s 143.036 ms (13.7%)
Agent iast 1.18 s 135.074 ms (12.9%)
Agent profiling 1.263 s 218.221 ms (20.9%)
Total tracing 10.591 s -
Total appsec 10.723 s 132.054 ms (1.2%)
Total iast 11.056 s 465.17 ms (4.4%)
Total profiling 10.839 s 247.801 ms (2.3%) 
gantt
    title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~d3c54a213e, baseline=1.47.0-SNAPSHOT~88f59f8817

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.206 ms) : 0, 716206
BytebuddyAgent [candidate] (716.298 ms) : 0, 716298
GlobalTracer [baseline] (242.907 ms) : 0, 242907
GlobalTracer [candidate] (243.929 ms) : 0, 243929
AppSec [baseline] (55.222 ms) : 0, 55222
AppSec [candidate] (55.314 ms) : 0, 55314
Remote Config [baseline] (720.953 µs) : 0, 721
Remote Config [candidate] (716.376 µs) : 0, 716
Telemetry [baseline] (13.082 ms) : 0, 13082
Telemetry [candidate] (13.611 ms) : 0, 13611
section appsec
BytebuddyAgent [baseline] (735.637 ms) : 0, 735637
BytebuddyAgent [candidate] (735.086 ms) : 0, 735086
GlobalTracer [baseline] (241.051 ms) : 0, 241051
GlobalTracer [candidate] (241.266 ms) : 0, 241266
AppSec [baseline] (176.382 ms) : 0, 176382
AppSec [candidate] (176.279 ms) : 0, 176279
Remote Config [baseline] (659.392 µs) : 0, 659
Remote Config [candidate] (666.752 µs) : 0, 667
Telemetry [baseline] (8.687 ms) : 0, 8687
Telemetry [candidate] (8.704 ms) : 0, 8704
IAST [baseline] (21.733 ms) : 0, 21733
IAST [candidate] (21.736 ms) : 0, 21736
section iast
BytebuddyAgent [baseline] (836.116 ms) : 0, 836116
BytebuddyAgent [candidate] (840.589 ms) : 0, 840589
GlobalTracer [baseline] (234.252 ms) : 0, 234252
GlobalTracer [candidate] (234.746 ms) : 0, 234746
AppSec [baseline] (56.815 ms) : 0, 56815
AppSec [candidate] (54.17 ms) : 0, 54170
Remote Config [baseline] (618.73 µs) : 0, 619
Remote Config [candidate] (609.064 µs) : 0, 609
Telemetry [baseline] (8.668 ms) : 0, 8668
Telemetry [candidate] (8.828 ms) : 0, 8828
IAST [baseline] (22.802 ms) : 0, 22802
IAST [candidate] (25.847 ms) : 0, 25847
section profiling
BytebuddyAgent [baseline] (708.27 ms) : 0, 708270
BytebuddyAgent [candidate] (707.669 ms) : 0, 707669
GlobalTracer [baseline] (352.716 ms) : 0, 352716
GlobalTracer [candidate] (353.847 ms) : 0, 353847
AppSec [baseline] (55.235 ms) : 0, 55235
AppSec [candidate] (54.159 ms) : 0, 54159
Remote Config [baseline] (704.505 µs) : 0, 705
Remote Config [candidate] (690.403 µs) : 0, 690
Telemetry [baseline] (8.862 ms) : 0, 8862
Telemetry [candidate] (8.894 ms) : 0, 8894
ProfilingAgent [baseline] (95.835 ms) : 0, 95835
ProfilingAgent [candidate] (95.655 ms) : 0, 95655
Profiling [baseline] (95.86 ms) : 0, 95860
Profiling [candidate] (95.68 ms) : 0, 95680
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~d3c54a213e, baseline=1.47.0-SNAPSHOT~88f59f8817

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.041 s) : 0, 1041418
Total [baseline] (8.627 s) : 0, 8626866
Agent [candidate] (1.044 s) : 0, 1043934
Total [candidate] (8.638 s) : 0, 8638389
section iast
Agent [baseline] (1.185 s) : 0, 1185214
Total [baseline] (9.206 s) : 0, 9206464
Agent [candidate] (1.188 s) : 0, 1188054
Total [candidate] (9.269 s) : 0, 9269061
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.18 s) : 0, 1179539
Total [baseline] (9.201 s) : 0, 9201237
Agent [candidate] (1.17 s) : 0, 1169536
Total [candidate] (9.2 s) : 0, 9199925
section iast_TELEMETRY_OFF
Agent [baseline] (1.177 s) : 0, 1176719
Total [baseline] (9.204 s) : 0, 9203565
Agent [candidate] (1.171 s) : 0, 1170904
Total [candidate] (9.237 s) : 0, 9237443
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.041 s -
Agent iast 1.185 s 143.796 ms (13.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.18 s 138.121 ms (13.3%)
Agent iast_TELEMETRY_OFF 1.177 s 135.301 ms (13.0%)
Total tracing 8.627 s -
Total iast 9.206 s 579.598 ms (6.7%)
Total iast_HARDCODED_SECRET_DISABLED 9.201 s 574.371 ms (6.7%)
Total iast_TELEMETRY_OFF 9.204 s 576.699 ms (6.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.044 s -
Agent iast 1.188 s 144.12 ms (13.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.17 s 125.602 ms (12.0%)
Agent iast_TELEMETRY_OFF 1.171 s 126.97 ms (12.2%)
Total tracing 8.638 s -
Total iast 9.269 s 630.672 ms (7.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.2 s 561.536 ms (6.5%)
Total iast_TELEMETRY_OFF 9.237 s 599.054 ms (6.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~d3c54a213e, baseline=1.47.0-SNAPSHOT~88f59f8817

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.082 ms) : 0, 716082
BytebuddyAgent [candidate] (715.717 ms) : 0, 715717
GlobalTracer [baseline] (242.834 ms) : 0, 242834
GlobalTracer [candidate] (243.329 ms) : 0, 243329
AppSec [baseline] (55.272 ms) : 0, 55272
AppSec [candidate] (55.22 ms) : 0, 55220
Remote Config [baseline] (713.553 µs) : 0, 714
Remote Config [candidate] (718.932 µs) : 0, 719
Telemetry [baseline] (11.452 ms) : 0, 11452
Telemetry [candidate] (13.707 ms) : 0, 13707
section iast
BytebuddyAgent [baseline] (843.599 ms) : 0, 843599
BytebuddyAgent [candidate] (847.061 ms) : 0, 847061
GlobalTracer [baseline] (236.159 ms) : 0, 236159
GlobalTracer [candidate] (236.196 ms) : 0, 236196
AppSec [baseline] (57.496 ms) : 0, 57496
AppSec [candidate] (55.506 ms) : 0, 55506
Remote Config [baseline] (621.563 µs) : 0, 622
Remote Config [candidate] (647.271 µs) : 0, 647
Telemetry [baseline] (8.763 ms) : 0, 8763
Telemetry [candidate] (8.82 ms) : 0, 8820
IAST [baseline] (23.269 ms) : 0, 23269
IAST [candidate] (24.367 ms) : 0, 24367
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (839.966 ms) : 0, 839966
BytebuddyAgent [candidate] (832.779 ms) : 0, 832779
GlobalTracer [baseline] (234.668 ms) : 0, 234668
GlobalTracer [candidate] (232.862 ms) : 0, 232862
AppSec [baseline] (57.142 ms) : 0, 57142
AppSec [candidate] (54.64 ms) : 0, 54640
Remote Config [baseline] (637.192 µs) : 0, 637
Remote Config [candidate] (608.49 µs) : 0, 608
Telemetry [baseline] (8.794 ms) : 0, 8794
Telemetry [candidate] (8.653 ms) : 0, 8653
IAST [baseline] (23.011 ms) : 0, 23011
IAST [candidate] (24.859 ms) : 0, 24859
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (837.839 ms) : 0, 837839
BytebuddyAgent [candidate] (832.227 ms) : 0, 832227
GlobalTracer [baseline] (234.84 ms) : 0, 234840
GlobalTracer [candidate] (234.178 ms) : 0, 234178
AppSec [baseline] (54.721 ms) : 0, 54721
AppSec [candidate] (55.153 ms) : 0, 55153
Remote Config [baseline] (621.165 µs) : 0, 621
Remote Config [candidate] (635.143 µs) : 0, 635
Telemetry [baseline] (8.618 ms) : 0, 8618
Telemetry [candidate] (8.76 ms) : 0, 8760
IAST [baseline] (24.743 ms) : 0, 24743
IAST [candidate] (24.635 ms) : 0, 24635
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-02-05T18:03:28 2025-02-05T18:10:32
git_branch master jb/old_code_cleanup
git_commit_date 1738775023 1738777786
git_commit_sha 88f59f8 d3c54a2
release_version 1.47.0-SNAPSHOT~88f59f8817 1.47.0-SNAPSHOT~d3c54a213e
start_time 2025-02-05T18:03:14 2025-02-05T18:10:18
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1738779390 1738779390
ci_job_id 795836735 795836735
ci_pipeline_id 55012587 55012587
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-9e4gtdsb-project-304-concurrent-1-glmh70dr 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-9e4gtdsb-project-304-concurrent-1-glmh70dr 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~d3c54a213e, baseline=1.47.0-SNAPSHOT~88f59f8817
    dateFormat X
    axisFormat %s
section baseline
no_agent (378.596 µs) : 358, 399
.   : milestone, 379,
iast (510.671 µs) : 489, 532
.   : milestone, 511,
iast_FULL (749.346 µs) : 727, 771
.   : milestone, 749,
iast_GLOBAL (553.675 µs) : 532, 576
.   : milestone, 554,
iast_HARDCODED_SECRET_DISABLED (507.93 µs) : 486, 529
.   : milestone, 508,
iast_INACTIVE (462.613 µs) : 441, 484
.   : milestone, 463,
iast_TELEMETRY_OFF (492.288 µs) : 471, 514
.   : milestone, 492,
tracing (453.146 µs) : 433, 474
.   : milestone, 453,
section candidate
no_agent (379.736 µs) : 359, 400
.   : milestone, 380,
iast (507.061 µs) : 485, 529
.   : milestone, 507,
iast_FULL (738.941 µs) : 717, 761
.   : milestone, 739,
iast_GLOBAL (553.887 µs) : 532, 576
.   : milestone, 554,
iast_HARDCODED_SECRET_DISABLED (506.591 µs) : 485, 528
.   : milestone, 507,
iast_INACTIVE (458.453 µs) : 437, 480
.   : milestone, 458,
iast_TELEMETRY_OFF (493.758 µs) : 472, 516
.   : milestone, 494,
tracing (452.882 µs) : 432, 474
.   : milestone, 453,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 378.596 µs [358.074 µs, 399.117 µs] -
iast 510.671 µs [488.897 µs, 532.445 µs] 132.075 µs (34.9%)
iast_FULL 749.346 µs [727.418 µs, 771.273 µs] 370.75 µs (97.9%)
iast_GLOBAL 553.675 µs [531.665 µs, 575.684 µs] 175.079 µs (46.2%)
iast_HARDCODED_SECRET_DISABLED 507.93 µs [486.371 µs, 529.49 µs] 129.335 µs (34.2%)
iast_INACTIVE 462.613 µs [441.126 µs, 484.099 µs] 84.017 µs (22.2%)
iast_TELEMETRY_OFF 492.288 µs [470.679 µs, 513.897 µs] 113.692 µs (30.0%)
tracing 453.146 µs [432.579 µs, 473.714 µs] 74.551 µs (19.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 379.736 µs [359.391 µs, 400.081 µs] -
iast 507.061 µs [485.401 µs, 528.721 µs] 127.324 µs (33.5%)
iast_FULL 738.941 µs [716.993 µs, 760.889 µs] 359.205 µs (94.6%)
iast_GLOBAL 553.887 µs [531.827 µs, 575.946 µs] 174.15 µs (45.9%)
iast_HARDCODED_SECRET_DISABLED 506.591 µs [484.887 µs, 528.295 µs] 126.855 µs (33.4%)
iast_INACTIVE 458.453 µs [437.383 µs, 479.523 µs] 78.716 µs (20.7%)
iast_TELEMETRY_OFF 493.758 µs [471.59 µs, 515.925 µs] 114.021 µs (30.0%)
tracing 452.882 µs [432.042 µs, 473.722 µs] 73.145 µs (19.3%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~d3c54a213e, baseline=1.47.0-SNAPSHOT~88f59f8817
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.364 ms) : 1344, 1384
.   : milestone, 1364,
appsec (1.74 ms) : 1717, 1763
.   : milestone, 1740,
appsec_no_iast (1.754 ms) : 1729, 1778
.   : milestone, 1754,
iast (1.505 ms) : 1480, 1529
.   : milestone, 1505,
profiling (1.544 ms) : 1519, 1568
.   : milestone, 1544,
tracing (1.482 ms) : 1456, 1508
.   : milestone, 1482,
section candidate
no_agent (1.363 ms) : 1343, 1382
.   : milestone, 1363,
appsec (1.753 ms) : 1729, 1777
.   : milestone, 1753,
appsec_no_iast (1.757 ms) : 1733, 1781
.   : milestone, 1757,
iast (1.503 ms) : 1479, 1528
.   : milestone, 1503,
profiling (1.517 ms) : 1494, 1540
.   : milestone, 1517,
tracing (1.487 ms) : 1463, 1511
.   : milestone, 1487,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.364 ms [1.344 ms, 1.384 ms] -
appsec 1.74 ms [1.717 ms, 1.763 ms] 375.345 µs (27.5%)
appsec_no_iast 1.754 ms [1.729 ms, 1.778 ms] 389.471 µs (28.5%)
iast 1.505 ms [1.48 ms, 1.529 ms] 140.506 µs (10.3%)
profiling 1.544 ms [1.519 ms, 1.568 ms] 179.328 µs (13.1%)
tracing 1.482 ms [1.456 ms, 1.508 ms] 117.742 µs (8.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.363 ms [1.343 ms, 1.382 ms] -
appsec 1.753 ms [1.729 ms, 1.777 ms] 390.338 µs (28.6%)
appsec_no_iast 1.757 ms [1.733 ms, 1.781 ms] 393.924 µs (28.9%)
iast 1.503 ms [1.479 ms, 1.528 ms] 140.681 µs (10.3%)
profiling 1.517 ms [1.494 ms, 1.54 ms] 154.54 µs (11.3%)
tracing 1.487 ms [1.463 ms, 1.511 ms] 124.628 µs (9.1%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jb/old_code_cleanup
git_commit_date 1738775023 1738777786
git_commit_sha 88f59f8 d3c54a2
release_version 1.47.0-SNAPSHOT~88f59f8817 1.47.0-SNAPSHOT~d3c54a213e
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1738779747 1738779747
ci_job_id 795836736 795836736
ci_pipeline_id 55012587 55012587
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-qndsgdz-project-304-concurrent-0-kkpek9jg 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-qndsgdz-project-304-concurrent-0-kkpek9jg 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~d3c54a213e, baseline=1.47.0-SNAPSHOT~88f59f8817
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.467 ms) : 1456, 1479
.   : milestone, 1467,
appsec (2.34 ms) : 2297, 2383
.   : milestone, 2340,
iast (2.104 ms) : 2049, 2159
.   : milestone, 2104,
iast_GLOBAL (2.148 ms) : 2093, 2203
.   : milestone, 2148,
profiling (2.459 ms) : 2268, 2649
.   : milestone, 2459,
tracing (1.924 ms) : 1882, 1965
.   : milestone, 1924,
section candidate
no_agent (1.468 ms) : 1456, 1479
.   : milestone, 1468,
appsec (2.361 ms) : 2317, 2404
.   : milestone, 2361,
iast (2.097 ms) : 2043, 2152
.   : milestone, 2097,
iast_GLOBAL (2.144 ms) : 2089, 2199
.   : milestone, 2144,
profiling (2.448 ms) : 2259, 2637
.   : milestone, 2448,
tracing (1.939 ms) : 1897, 1982
.   : milestone, 1939,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.456 ms, 1.479 ms] -
appsec 2.34 ms [2.297 ms, 2.383 ms] 872.453 µs (59.5%)
iast 2.104 ms [2.049 ms, 2.159 ms] 636.704 µs (43.4%)
iast_GLOBAL 2.148 ms [2.093 ms, 2.203 ms] 681.021 µs (46.4%)
profiling 2.459 ms [2.268 ms, 2.649 ms] 991.206 µs (67.5%)
tracing 1.924 ms [1.882 ms, 1.965 ms] 456.356 µs (31.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.468 ms [1.456 ms, 1.479 ms] -
appsec 2.361 ms [2.317 ms, 2.404 ms] 892.561 µs (60.8%)
iast 2.097 ms [2.043 ms, 2.152 ms] 629.361 µs (42.9%)
iast_GLOBAL 2.144 ms [2.089 ms, 2.199 ms] 675.723 µs (46.0%)
profiling 2.448 ms [2.259 ms, 2.637 ms] 979.874 µs (66.8%)
tracing 1.939 ms [1.897 ms, 1.982 ms] 471.454 µs (32.1%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~d3c54a213e, baseline=1.47.0-SNAPSHOT~88f59f8817
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.875 s) : 14875000, 14875000
.   : milestone, 14875000,
appsec (15.206 s) : 15206000, 15206000
.   : milestone, 15206000,
iast (18.106 s) : 18106000, 18106000
.   : milestone, 18106000,
iast_GLOBAL (18.096 s) : 18096000, 18096000
.   : milestone, 18096000,
profiling (15.537 s) : 15537000, 15537000
.   : milestone, 15537000,
tracing (15.002 s) : 15002000, 15002000
.   : milestone, 15002000,
section candidate
no_agent (14.996 s) : 14996000, 14996000
.   : milestone, 14996000,
appsec (14.924 s) : 14924000, 14924000
.   : milestone, 14924000,
iast (18.579 s) : 18579000, 18579000
.   : milestone, 18579000,
iast_GLOBAL (18.255 s) : 18255000, 18255000
.   : milestone, 18255000,
profiling (15.053 s) : 15053000, 15053000
.   : milestone, 15053000,
tracing (15.052 s) : 15052000, 15052000
.   : milestone, 15052000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.875 s [14.875 s, 14.875 s] -
appsec 15.206 s [15.206 s, 15.206 s] 331.0 ms (2.2%)
iast 18.106 s [18.106 s, 18.106 s] 3.231 s (21.7%)
iast_GLOBAL 18.096 s [18.096 s, 18.096 s] 3.221 s (21.7%)
profiling 15.537 s [15.537 s, 15.537 s] 662.0 ms (4.5%)
tracing 15.002 s [15.002 s, 15.002 s] 127.0 ms (0.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.996 s [14.996 s, 14.996 s] -
appsec 14.924 s [14.924 s, 14.924 s] -72.0 ms (-0.5%)
iast 18.579 s [18.579 s, 18.579 s] 3.583 s (23.9%)
iast_GLOBAL 18.255 s [18.255 s, 18.255 s] 3.259 s (21.7%)
profiling 15.053 s [15.053 s, 15.053 s] 57.0 ms (0.4%)
tracing 15.052 s [15.052 s, 15.052 s] 56.0 ms (0.4%)

@jbachorik jbachorik marked this pull request as ready for review February 6, 2025 11:58
@jbachorik jbachorik requested review from a team as code owners February 6, 2025 11:58
@jbachorik jbachorik requested a review from dougqh February 6, 2025 11:58
@jbachorik jbachorik merged commit 8a74e85 into master Feb 6, 2025
201 checks passed
@jbachorik jbachorik deleted the jb/old_code_cleanup branch February 6, 2025 15:00
@github-actions github-actions bot added this to the 1.47.0 milestone Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: profiling Profiling tag: no release notes Changes to exclude from release notes type: refactoring
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jbachorik @PerfectSlayer