-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support testing of latest quartz versions #7948
Conversation
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
410d88c
to
4fc9db9
Compare
4fc9db9
to
4e3b0f6
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~4e3b0f6e56, baseline=1.43.0-SNAPSHOT~0d284c0b36
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.079 s) : 0, 1078708
Total [baseline] (8.567 s) : 0, 8567038
Agent [candidate] (1.077 s) : 0, 1077190
Total [candidate] (8.547 s) : 0, 8546805
section iast
Agent [baseline] (1.203 s) : 0, 1202612
Total [baseline] (9.165 s) : 0, 9165130
Agent [candidate] (1.203 s) : 0, 1202784
Total [candidate] (9.112 s) : 0, 9111527
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.212 s) : 0, 1211837
Total [baseline] (9.11 s) : 0, 9110021
Agent [candidate] (1.206 s) : 0, 1205731
Total [candidate] (9.139 s) : 0, 9139088
section iast_TELEMETRY_OFF
Agent [baseline] (1.202 s) : 0, 1201513
Total [baseline] (9.096 s) : 0, 9095776
Agent [candidate] (1.217 s) : 0, 1216602
Total [candidate] (9.123 s) : 0, 9123192
gantt
title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~4e3b0f6e56, baseline=1.43.0-SNAPSHOT~0d284c0b36
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.624 ms) : 0, 686624
BytebuddyAgent [candidate] (684.913 ms) : 0, 684913
GlobalTracer [baseline] (314.454 ms) : 0, 314454
GlobalTracer [candidate] (314.0 ms) : 0, 314000
AppSec [baseline] (54.108 ms) : 0, 54108
AppSec [candidate] (54.1 ms) : 0, 54100
Remote Config [baseline] (684.627 µs) : 0, 685
Remote Config [candidate] (676.728 µs) : 0, 677
Telemetry [baseline] (9.221 ms) : 0, 9221
Telemetry [candidate] (9.899 ms) : 0, 9899
section iast
BytebuddyAgent [baseline] (800.296 ms) : 0, 800296
BytebuddyAgent [candidate] (800.236 ms) : 0, 800236
GlobalTracer [baseline] (302.323 ms) : 0, 302323
GlobalTracer [candidate] (303.191 ms) : 0, 303191
AppSec [baseline] (56.784 ms) : 0, 56784
AppSec [candidate] (56.379 ms) : 0, 56379
Remote Config [baseline] (606.749 µs) : 0, 607
Remote Config [candidate] (605.931 µs) : 0, 606
Telemetry [baseline] (7.527 ms) : 0, 7527
Telemetry [candidate] (7.385 ms) : 0, 7385
IAST [baseline] (21.47 ms) : 0, 21470
IAST [candidate] (21.372 ms) : 0, 21372
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (806.497 ms) : 0, 806497
BytebuddyAgent [candidate] (800.871 ms) : 0, 800871
GlobalTracer [baseline] (305.013 ms) : 0, 305013
GlobalTracer [candidate] (304.213 ms) : 0, 304213
AppSec [baseline] (57.805 ms) : 0, 57805
AppSec [candidate] (57.234 ms) : 0, 57234
Remote Config [baseline] (613.203 µs) : 0, 613
Remote Config [candidate] (614.217 µs) : 0, 614
Telemetry [baseline] (7.484 ms) : 0, 7484
Telemetry [candidate] (7.576 ms) : 0, 7576
IAST [baseline] (20.721 ms) : 0, 20721
IAST [candidate] (21.643 ms) : 0, 21643
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (798.891 ms) : 0, 798891
BytebuddyAgent [candidate] (809.773 ms) : 0, 809773
GlobalTracer [baseline] (303.035 ms) : 0, 303035
GlobalTracer [candidate] (306.304 ms) : 0, 306304
AppSec [baseline] (57.0 ms) : 0, 57000
AppSec [candidate] (56.599 ms) : 0, 56599
Remote Config [baseline] (600.202 µs) : 0, 600
Remote Config [candidate] (608.606 µs) : 0, 609
Telemetry [baseline] (7.317 ms) : 0, 7317
Telemetry [candidate] (7.429 ms) : 0, 7429
IAST [baseline] (21.061 ms) : 0, 21061
IAST [candidate] (22.091 ms) : 0, 22091
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~4e3b0f6e56, baseline=1.43.0-SNAPSHOT~0d284c0b36
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.085 s) : 0, 1084868
Total [baseline] (10.396 s) : 0, 10396427
Agent [candidate] (1.079 s) : 0, 1078651
Total [candidate] (10.335 s) : 0, 10335333
section appsec
Agent [baseline] (1.211 s) : 0, 1210749
Total [baseline] (10.637 s) : 0, 10637181
Agent [candidate] (1.214 s) : 0, 1214132
Total [candidate] (10.677 s) : 0, 10677382
section iast
Agent [baseline] (1.209 s) : 0, 1209342
Total [baseline] (10.926 s) : 0, 10926136
Agent [candidate] (1.216 s) : 0, 1216133
Total [candidate] (10.958 s) : 0, 10958006
section profiling
Agent [baseline] (1.274 s) : 0, 1274145
Total [baseline] (10.719 s) : 0, 10719191
Agent [candidate] (1.276 s) : 0, 1275654
Total [candidate] (10.661 s) : 0, 10661091
gantt
title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~4e3b0f6e56, baseline=1.43.0-SNAPSHOT~0d284c0b36
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (690.263 ms) : 0, 690263
BytebuddyAgent [candidate] (685.099 ms) : 0, 685099
GlobalTracer [baseline] (315.927 ms) : 0, 315927
GlobalTracer [candidate] (313.946 ms) : 0, 313946
AppSec [baseline] (54.409 ms) : 0, 54409
AppSec [candidate] (54.062 ms) : 0, 54062
Remote Config [baseline] (680.161 µs) : 0, 680
Remote Config [candidate] (681.285 µs) : 0, 681
Telemetry [baseline] (9.92 ms) : 0, 9920
Telemetry [candidate] (11.271 ms) : 0, 11271
section appsec
BytebuddyAgent [baseline] (701.837 ms) : 0, 701837
BytebuddyAgent [candidate] (703.766 ms) : 0, 703766
GlobalTracer [baseline] (311.649 ms) : 0, 311649
GlobalTracer [candidate] (312.684 ms) : 0, 312684
AppSec [baseline] (164.893 ms) : 0, 164893
AppSec [candidate] (166.332 ms) : 0, 166332
Remote Config [baseline] (634.998 µs) : 0, 635
Remote Config [candidate] (638.586 µs) : 0, 639
Telemetry [baseline] (8.491 ms) : 0, 8491
Telemetry [candidate] (7.438 ms) : 0, 7438
IAST [baseline] (19.392 ms) : 0, 19392
IAST [candidate] (19.301 ms) : 0, 19301
section iast
BytebuddyAgent [baseline] (804.877 ms) : 0, 804877
BytebuddyAgent [candidate] (811.46 ms) : 0, 811460
GlobalTracer [baseline] (304.285 ms) : 0, 304285
GlobalTracer [candidate] (305.014 ms) : 0, 305014
AppSec [baseline] (57.467 ms) : 0, 57467
AppSec [candidate] (55.597 ms) : 0, 55597
Remote Config [baseline] (619.407 µs) : 0, 619
Remote Config [candidate] (623.383 µs) : 0, 623
Telemetry [baseline] (7.547 ms) : 0, 7547
Telemetry [candidate] (7.391 ms) : 0, 7391
IAST [baseline] (20.886 ms) : 0, 20886
IAST [candidate] (22.264 ms) : 0, 22264
section profiling
BytebuddyAgent [baseline] (678.611 ms) : 0, 678611
BytebuddyAgent [candidate] (680.214 ms) : 0, 680214
GlobalTracer [baseline] (397.593 ms) : 0, 397593
GlobalTracer [candidate] (397.76 ms) : 0, 397760
AppSec [baseline] (54.421 ms) : 0, 54421
AppSec [candidate] (54.442 ms) : 0, 54442
Remote Config [baseline] (666.746 µs) : 0, 667
Remote Config [candidate] (665.563 µs) : 0, 666
Telemetry [baseline] (11.953 ms) : 0, 11953
Telemetry [candidate] (13.235 ms) : 0, 13235
ProfilingAgent [baseline] (92.221 ms) : 0, 92221
ProfilingAgent [candidate] (90.609 ms) : 0, 90609
Profiling [baseline] (92.244 ms) : 0, 92244
Profiling [candidate] (90.633 ms) : 0, 90633
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~4e3b0f6e56, baseline=1.43.0-SNAPSHOT~0d284c0b36
dateFormat X
axisFormat %s
section baseline
no_agent (1.341 ms) : 1321, 1360
. : milestone, 1341,
appsec (1.75 ms) : 1725, 1775
. : milestone, 1750,
appsec_no_iast (1.728 ms) : 1703, 1753
. : milestone, 1728,
iast (1.485 ms) : 1462, 1508
. : milestone, 1485,
profiling (1.481 ms) : 1458, 1504
. : milestone, 1481,
tracing (1.475 ms) : 1450, 1500
. : milestone, 1475,
section candidate
no_agent (1.354 ms) : 1335, 1374
. : milestone, 1354,
appsec (1.74 ms) : 1715, 1765
. : milestone, 1740,
appsec_no_iast (1.743 ms) : 1719, 1767
. : milestone, 1743,
iast (1.487 ms) : 1464, 1510
. : milestone, 1487,
profiling (1.5 ms) : 1477, 1523
. : milestone, 1500,
tracing (1.487 ms) : 1463, 1511
. : milestone, 1487,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~4e3b0f6e56, baseline=1.43.0-SNAPSHOT~0d284c0b36
dateFormat X
axisFormat %s
section baseline
no_agent (374.461 µs) : 351, 398
. : milestone, 374,
iast (487.379 µs) : 466, 509
. : milestone, 487,
iast_FULL (647.384 µs) : 626, 669
. : milestone, 647,
iast_GLOBAL (507.077 µs) : 486, 528
. : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (484.99 µs) : 464, 506
. : milestone, 485,
iast_INACTIVE (445.044 µs) : 425, 466
. : milestone, 445,
iast_TELEMETRY_OFF (476.911 µs) : 456, 498
. : milestone, 477,
tracing (447.849 µs) : 427, 469
. : milestone, 448,
section candidate
no_agent (373.197 µs) : 354, 393
. : milestone, 373,
iast (490.619 µs) : 469, 512
. : milestone, 491,
iast_FULL (649.443 µs) : 628, 671
. : milestone, 649,
iast_GLOBAL (520.135 µs) : 498, 542
. : milestone, 520,
iast_HARDCODED_SECRET_DISABLED (490.022 µs) : 469, 511
. : milestone, 490,
iast_INACTIVE (447.897 µs) : 427, 468
. : milestone, 448,
iast_TELEMETRY_OFF (478.59 µs) : 458, 499
. : milestone, 479,
tracing (454.507 µs) : 433, 476
. : milestone, 455,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~4e3b0f6e56, baseline=1.43.0-SNAPSHOT~0d284c0b36
dateFormat X
axisFormat %s
section baseline
no_agent (1.459 ms) : 1447, 1470
. : milestone, 1459,
appsec (2.313 ms) : 2273, 2353
. : milestone, 2313,
iast (2.065 ms) : 2013, 2116
. : milestone, 2065,
iast_GLOBAL (2.11 ms) : 2058, 2162
. : milestone, 2110,
profiling (1.939 ms) : 1897, 1980
. : milestone, 1939,
tracing (1.911 ms) : 1871, 1951
. : milestone, 1911,
section candidate
no_agent (1.462 ms) : 1450, 1473
. : milestone, 1462,
appsec (2.317 ms) : 2276, 2358
. : milestone, 2317,
iast (2.067 ms) : 2015, 2120
. : milestone, 2067,
iast_GLOBAL (2.096 ms) : 2045, 2147
. : milestone, 2096,
profiling (1.935 ms) : 1892, 1977
. : milestone, 1935,
tracing (1.914 ms) : 1875, 1953
. : milestone, 1914,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~4e3b0f6e56, baseline=1.43.0-SNAPSHOT~0d284c0b36
dateFormat X
axisFormat %s
section baseline
no_agent (15.772 s) : 15772000, 15772000
. : milestone, 15772000,
appsec (15.317 s) : 15317000, 15317000
. : milestone, 15317000,
iast (19.26 s) : 19260000, 19260000
. : milestone, 19260000,
iast_GLOBAL (18.208 s) : 18208000, 18208000
. : milestone, 18208000,
profiling (15.024 s) : 15024000, 15024000
. : milestone, 15024000,
tracing (15.084 s) : 15084000, 15084000
. : milestone, 15084000,
section candidate
no_agent (15.099 s) : 15099000, 15099000
. : milestone, 15099000,
appsec (15.271 s) : 15271000, 15271000
. : milestone, 15271000,
iast (18.889 s) : 18889000, 18889000
. : milestone, 18889000,
iast_GLOBAL (18.232 s) : 18232000, 18232000
. : milestone, 18232000,
profiling (15.566 s) : 15566000, 15566000
. : milestone, 15566000,
tracing (15.328 s) : 15328000, 15328000
. : milestone, 15328000,
|
* Finish netty span when request is cancelled (#7900) * Finish netty span when request is cancelled * Propagate channelInactive to next handler * Support testing of latest quartz versions (#7948) --------- Co-authored-by: Andrea Marziali <[email protected]>
What Does This Do
Support testing of latest 2.4.0 and 2.5.0 quartz releases
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]