Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename packages for consistency #23

Merged
merged 2 commits into from
Jun 29, 2017
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dd-java-agent-ittests/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -250,8 +250,8 @@
</transformer>
<transformer implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
<manifestEntries>
<Agent-Class>io.opentracing.contrib.agent.AnnotationsTracingAgent</Agent-Class>
<Premain-Class>io.opentracing.contrib.agent.AnnotationsTracingAgent
<Agent-Class>com.datadoghq.trace.agent.AnnotationsTracingAgent</Agent-Class>
<Premain-Class>com.datadoghq.trace.agent.AnnotationsTracingAgent
</Premain-Class>
<Can-Redefine-Classes>true</Can-Redefine-Classes>
<Can-Retransform-Classes>true</Can-Retransform-Classes>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package io.opentracing.contrib.agent;
package com.datadoghq.trace.agent;

import com.datadog.trace.Trace;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be datadoghq


public class SayTracedHello {

Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
package io.opentracing.contrib.agent;
package com.datadoghq.trace.agent;

import static org.assertj.core.api.Assertions.assertThat;

import org.junit.Before;
import org.junit.Test;

import com.datadoghq.trace.instrument.AAgentIntegration;
import com.datadoghq.trace.agent.integration.AAgentIntegration;

public class TraceAnnotationsManagerTest extends AAgentIntegration{

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.datadoghq.trace.instrument;
package com.datadoghq.trace.agent.integration;

import org.junit.Before;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.datadoghq.trace.instrument;
package com.datadoghq.trace.agent.integration;

import com.amazonaws.regions.Regions;
import com.amazonaws.services.s3.AmazonS3ClientBuilder;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,15 +1,9 @@
package com.datadoghq.trace.instrument;
package com.datadoghq.trace.agent.integration;

import io.opentracing.contrib.apache.http.client.TracingHttpClientBuilder;
import org.apache.http.HttpResponse;
import org.apache.http.client.HttpClient;
import org.apache.http.client.methods.HttpGet;
import org.apache.http.impl.client.HttpClientBuilder;
import org.junit.Test;

import java.io.BufferedReader;
import java.io.InputStreamReader;

import static org.assertj.core.api.Assertions.assertThat;

public class ApacheHTTPClientTest extends AAgentIntegration {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.datadoghq.trace.instrument;
package com.datadoghq.trace.agent.integration;

import com.datastax.driver.core.Cluster;
import com.datastax.driver.core.Session;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.datadoghq.trace.instrument;
package com.datadoghq.trace.agent.integration;

import io.opentracing.contrib.jms.TracingMessageProducer;
import io.opentracing.contrib.jms.common.TracingMessageConsumer;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.datadoghq.trace.instrument;
package com.datadoghq.trace.agent.integration;

import static org.assertj.core.api.Assertions.assertThat;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.datadoghq.trace.instrument;
package com.datadoghq.trace.agent.integration;

import static org.assertj.core.api.Assertions.assertThat;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.datadoghq.trace.instrument;
package com.datadoghq.trace.agent.integration;

import static org.assertj.core.api.Assertions.assertThat;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.datadoghq.trace.instrument;
package com.datadoghq.trace.agent.integration;

import static org.assertj.core.api.Assertions.assertThat;

Expand Down
20 changes: 10 additions & 10 deletions dd-java-agent/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
<version>0.9.11</version>
</dependency>

<!-- Server side instrumentation -->
<!-- Server sintegrationtion -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something went wrong here

<dependency>
<groupId>io.opentracing.contrib</groupId>
<artifactId>opentracing-web-servlet-filter</artifactId>
Expand All @@ -85,7 +85,7 @@
<scope>provided</scope>
</dependency>

<!-- Mongo instrumentation -->
<!-- Mointegrationtion -->
<dependency>
<groupId>io.opentracing.contrib</groupId>
<artifactId>opentracing-mongo-driver</artifactId>
Expand Down Expand Up @@ -121,7 +121,7 @@
<version>${ot.contrib.jdbc.version}</version>
</dependency>

<!-- Client side instrumentation -->
<!-- Client sintegrationtion -->
<dependency>
<groupId>io.opentracing.contrib</groupId>
<artifactId>opentracing-okhttp3</artifactId>
Expand All @@ -140,7 +140,7 @@
<scope>provided</scope>
</dependency>

<!-- JMS instrumentation -->
<!-- integrationtion -->
<dependency>
<groupId>io.opentracing.contrib</groupId>
<artifactId>opentracing-jms-2</artifactId>
Expand All @@ -159,7 +159,7 @@
<scope>provided</scope>
</dependency>

<!-- AWS SDK instrumentation -->
<!-- AWS integrationtion -->
<dependency>
<groupId>io.opentracing.contrib</groupId>
<artifactId>opentracing-aws-sdk</artifactId>
Expand All @@ -178,7 +178,7 @@
<scope>provided</scope>
</dependency>

<!-- Cassandra instrumentation -->
<!-- Cassanintegrationtion -->
<dependency>
<groupId>io.opentracing.contrib</groupId>
<artifactId>opentracing-cassandra-driver</artifactId>
Expand All @@ -197,7 +197,7 @@
<scope>provided</scope>
</dependency>

<!-- Elasticsearch instrumentation -->
<!-- Elasticseaintegrationtion -->
<dependency>
<groupId>io.opentracing.contrib</groupId>
<artifactId>opentracing-elasticsearch-client</artifactId>
Expand All @@ -216,7 +216,7 @@
<scope>provided</scope>
</dependency>

<!-- Apache HTTP instrumentation -->
<!-- Apache Hintegrationtion -->
<dependency>
<groupId>io.opentracing.contrib</groupId>
<artifactId>opentracing-apache-httpclient</artifactId>
Expand Down Expand Up @@ -293,8 +293,8 @@
</transformer>
<transformer implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
<manifestEntries>
<Agent-Class>io.opentracing.contrib.agent.AnnotationsTracingAgent</Agent-Class>
<Premain-Class>io.opentracing.contrib.agent.AnnotationsTracingAgent
<Agent-Class>com.datadoghq.trace.agent.AnnotationsTracingAgent</Agent-Class>
<Premain-Class>com.datadoghq.trace.agent.AnnotationsTracingAgent
</Premain-Class>
<Can-Redefine-Classes>true</Can-Redefine-Classes>
<Can-Retransform-Classes>true</Can-Retransform-Classes>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package com.datadoghq.trace.resolver;
package com.datadoghq.trace.agent;

import com.datadoghq.trace.resolver.TracerConfig;

import java.util.ArrayList;
import java.util.List;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package io.opentracing.contrib.agent;
package com.datadoghq.trace.agent;

import io.opentracing.contrib.agent.OpenTracingAgent;

import java.lang.instrument.Instrumentation;

Expand Down Expand Up @@ -42,7 +44,7 @@ protected static String addManager(String agentArgs) {
} else {
agentArgs += ",";
}
agentArgs += "manager:"+io.opentracing.contrib.agent.TraceAnnotationsManager.class.getName();
agentArgs += "manager:" + TraceAnnotationsManager.class.getName();

return agentArgs;
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package io.opentracing.contrib.agent;
package com.datadoghq.trace.agent;

import com.datadoghq.trace.resolver.FactoryUtils;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package io.opentracing.contrib.agent;
package com.datadoghq.trace.agent;

import com.datadoghq.trace.resolver.AgentTracerConfig;
import com.datadog.trace.Trace;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be datadoghq, no?

import com.datadoghq.trace.resolver.DDTracerFactory;
import com.datadoghq.trace.resolver.FactoryUtils;
import javassist.ClassPool;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package io.opentracing.contrib.agent.helper;
package com.datadoghq.trace.agent.integration;

import com.amazonaws.client.builder.AwsClientBuilder;
import com.amazonaws.handlers.RequestHandler2;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package io.opentracing.contrib.agent.helper;
package com.datadoghq.trace.agent.integration;

import io.opentracing.contrib.apache.http.client.TracingHttpClientBuilder;
import org.apache.http.impl.client.HttpClientBuilder;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package io.opentracing.contrib.agent.helper;
package com.datadoghq.trace.agent.integration;

import com.datastax.driver.core.Session;
import io.opentracing.Tracer;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package io.opentracing.contrib.agent.helper;
package com.datadoghq.trace.agent.integration;

import io.opentracing.NoopTracerFactory;
import io.opentracing.Tracer;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package io.opentracing.contrib.agent.helper;
package com.datadoghq.trace.agent.integration;

import io.opentracing.ActiveSpan;
import io.opentracing.Span;
Expand All @@ -12,7 +12,7 @@

/**
* Instrument all Elasticsearch queries.
* We have not found a way to inject the opentracing contribution, so this helper is the instrumentation.
* We have not found a way to inject the opentracing contribution, so this integration is the integration.
* FIXME find a better to way to inject the OT contrib
*/
public class ElasticsearchHelper extends DDAgentTracingHelper<ActionListener> {
Expand All @@ -24,7 +24,7 @@ public ElasticsearchHelper(Rule rule) {
private Object request;

/**
* This method is used to register/save some object that will be used for the instrumentation.
* This method is used to register/save some object that will be used for the integration.
* Currently, we need to keep a reference of the request called
*
* @param request The request used for the query
Expand All @@ -39,7 +39,7 @@ public ActionListener patch(ActionListener listener) {
}

/**
* Strategy: When a query is executed, if start the instrumentation and a new Span.
* Strategy: When a query is executed, if start the integration and a new Span.
* We override the default FutureAction by using the one provided in the opentracing contribution.
*
* @param listener default listener
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package io.opentracing.contrib.agent.helper;
package com.datadoghq.trace.agent.integration;

import io.opentracing.contrib.jms.common.TracingMessageConsumer;
import org.jboss.byteman.rule.Rule;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package io.opentracing.contrib.agent.helper;
package com.datadoghq.trace.agent.integration;

import io.opentracing.contrib.jms.TracingMessageProducer;
import org.jboss.byteman.rule.Rule;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package io.opentracing.contrib.agent.helper;
package com.datadoghq.trace.agent.integration;

import io.opentracing.contrib.web.servlet.filter.TracingFilter;
import org.eclipse.jetty.servlet.ServletContextHandler;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package io.opentracing.contrib.agent.helper;
package com.datadoghq.trace.agent.integration;

import com.mongodb.MongoClientOptions;
import io.opentracing.contrib.mongo.TracingCommandListener;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package io.opentracing.contrib.agent.helper;
package com.datadoghq.trace.agent.integration;

import io.opentracing.contrib.okhttp3.TracingInterceptor;
import okhttp3.OkHttpClient;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package io.opentracing.contrib.agent.helper;
package com.datadoghq.trace.agent.integration;

import io.opentracing.contrib.web.servlet.filter.TracingFilter;
import org.apache.catalina.core.ApplicationContext;
Expand Down
Loading