Skip to content

Commit

Permalink
Disable smap RSS parsing by default (#8342)
Browse files Browse the repository at this point in the history
* Disable smap RSS parsing by default

* Reduce logging level for smap scraping
  • Loading branch information
MattAlp authored Feb 6, 2025
1 parent ee5772f commit 97961ff
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -755,12 +755,13 @@ private static synchronized void registerSmapEntryEvent() {
"com.datadog.profiling.controller.openjdk.events.SmapEntryFactory");
final Method registerMethod = smapFactoryClass.getMethod("registerEvents");
registerMethod.invoke(null);
} catch (final NoClassDefFoundError
} catch (final NoSuchMethodException
| NoClassDefFoundError
| ClassNotFoundException
| UnsupportedClassVersionError ignored) {
| UnsupportedClassVersionError
| IllegalAccessException
| InvocationTargetException ignored) {
log.debug("Smap entry scraping not supported");
} catch (final Throwable ex) {
log.error("Unable to initialize smap entry scraping", ex);
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -208,12 +208,12 @@ public final class ProfilingConfig {
public static final String PROFILING_SMAP_COLLECTION_ENABLED =
"profiling.smap.collection.enabled";

public static final boolean PROFILING_SMAP_COLLECTION_ENABLED_DEFAULT = true;
public static final boolean PROFILING_SMAP_COLLECTION_ENABLED_DEFAULT = false;

public static final String PROFILING_SMAP_AGGREGATION_ENABLED =
"profiling.smap.aggregation.enabled";

public static final boolean PROFILING_SMAP_AGGREGATION_ENABLED_DEFAULT = true;
public static final boolean PROFILING_SMAP_AGGREGATION_ENABLED_DEFAULT = false;

public static final String PROFILING_QUEUEING_TIME_THRESHOLD_MILLIS =
"profiling.queueing.time.threshold.millis";
Expand Down

0 comments on commit 97961ff

Please sign in to comment.