Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/internal/httptrace: add inferred span identification tag #3184

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

zarirhamza
Copy link
Contributor

@zarirhamza zarirhamza commented Feb 13, 2025

What does this PR do?

Adds _dd.inferred_span tag to ID inferred span tags

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@zarirhamza zarirhamza requested review from a team as code owners February 13, 2025 16:39
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Feb 13, 2025
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 13, 2025

Datadog Report

Branch report: zarir/inferred_span_tag
Commit report: 9541c59
Test service: dd-trace-go

✅ 0 Failed, 5235 Passed, 73 Skipped, 1m 48.73s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Feb 13, 2025

Benchmarks

Benchmark execution time: 2025-02-13 18:21:43

Comparing candidate commit f18cb33 in PR branch zarir/inferred_span_tag with baseline commit 9eb2e61 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 0 unstable metrics.

Copy link
Contributor

@hannahkm hannahkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Failing orchestrion test seems to be unrelated; try rerunning to see if it passes.

Also, please cherry pick the PR to the v2-dev branch! Or DM me if you'd like one of us to do it instead.

@zarirhamza zarirhamza enabled auto-merge (squash) February 13, 2025 18:40
@zarirhamza zarirhamza merged commit c345adb into main Feb 13, 2025
173 checks passed
@zarirhamza zarirhamza deleted the zarir/inferred_span_tag branch February 13, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants