Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) internal/civisibility: Fix test visibility on Go 1.24 #3179

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

tonyredondo
Copy link
Member

@tonyredondo tonyredondo commented Feb 13, 2025

What does this PR do?

This PR fixes Test Visibility on Go 1.24

V2: (fix) internal/civisibility: Fix test visibility on Go 1.24 - v2

Motivation

Test visibility instrumentation depends on some internal Go fields. Go 1.24 came with some changes on those internals, this PR fixes that.

  • This PR also fixes an existing bug we had by casting a sync.Mutex to sync.RWMutex

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 13, 2025

Datadog Report

Branch report: tony/civisibility-fix-go-1.24
Commit report: 0e8edd6
Test service: dd-trace-go

✅ 0 Failed, 5232 Passed, 73 Skipped, 2m 6.19s Total Time

@tonyredondo tonyredondo self-assigned this Feb 13, 2025
@tonyredondo tonyredondo marked this pull request as ready for review February 13, 2025 11:26
@tonyredondo tonyredondo requested review from a team as code owners February 13, 2025 11:26
@pr-commenter
Copy link

pr-commenter bot commented Feb 13, 2025

Benchmarks

Benchmark execution time: 2025-02-13 11:41:05

Comparing candidate commit da1804f in PR branch tony/civisibility-fix-go-1.24 with baseline commit 7125f59 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 0 unstable metrics.

@tonyredondo tonyredondo enabled auto-merge (squash) February 13, 2025 11:45
@tonyredondo tonyredondo merged commit a153c0d into main Feb 13, 2025
173 checks passed
@tonyredondo tonyredondo deleted the tony/civisibility-fix-go-1.24 branch February 13, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants