Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) internal/civisibility: change http default values and reduce test time (V2) #3135

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

tonyredondo
Copy link
Member

What does this PR do?

This PR changes the defaults of the CI Visibility http clients, Currently in the worst case scenario the client were blocking the test process up to 60 seconds. This PR reduces this time by changing the constant default values. As a direct impact, this change reduces the time for testing the package.

V1: #3134

Motivation

The current defaults are too large...

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@pr-commenter
Copy link

pr-commenter bot commented Jan 31, 2025

Benchmarks

Benchmark execution time: 2025-01-31 14:49:27

Comparing candidate commit c38f1af in PR branch tony/civisibility-change-defaults-v2 with baseline commit 2641e5d in branch v2-dev.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 1 unstable metrics.

@hannahkm hannahkm merged commit 36f7fad into v2-dev Jan 31, 2025
2 checks passed
@hannahkm hannahkm deleted the tony/civisibility-change-defaults-v2 branch January 31, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants