Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(staticcheck): Fix trivial go vet issues #3091

Merged
merged 1 commit into from
Jan 16, 2025
Merged

fix(staticcheck): Fix trivial go vet issues #3091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contrib/jackc/pgx.v5/example_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ func ExampleConnect() {
}
}

func ExamplePool() {
func ExampleNewPool() {
ctx := context.TODO()

// The pgxpool uses the same tracer and is exposed the same way.
Expand Down
1 change: 0 additions & 1 deletion contrib/labstack/echo.v4/appsec_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,6 @@ func TestControlFlow(t *testing.T) {
},
handler: func(echo.Context) error {
panic("unexpected control flow")
return nil
},
test: func(t *testing.T, rec *httptest.ResponseRecorder, mt mocktracer.Tracer, err error) {
require.Error(t, err)
Expand Down
3 changes: 2 additions & 1 deletion internal/utils_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ func BenchmarkIter(b *testing.B) {

func TestLockMapThrash(t *testing.T) {
wg := sync.WaitGroup{}
ctx, _ := context.WithTimeout(context.Background(), 20*time.Millisecond)
ctx, cancel := context.WithTimeout(context.Background(), 20*time.Millisecond)
t.Cleanup(cancel)
lm := NewLockMap(map[string]string{})
wg.Add(6)
for i := 0; i < 3; i++ {
Expand Down
Loading