Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) internal/civisibility/utils: improve environment tags mutability #3076

Merged

Conversation

tonyredondo
Copy link
Member

@tonyredondo tonyredondo commented Jan 10, 2025

What does this PR do?

This PR improves the mutability over the environment tags, avoiding to re-running the Cmds (git commands) after adding new tags and avoiding race conditions.

Same PR for v2-dev: #3077

Ticket: SDTEST-1424

Motivation

Currently if we add a new tag we end up by re running the git command to create a new map, this PR fixes this issue.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 10, 2025

Datadog Report

Branch report: tony/civisibility-improve-environment-tags-mutability
Commit report: f489bb8
Test service: dd-trace-go

✅ 0 Failed, 5127 Passed, 70 Skipped, 2m 27.75s Total Time

@tonyredondo tonyredondo force-pushed the tony/civisibility-improve-environment-tags-mutability branch from 9531f7b to 35f1c3c Compare January 10, 2025 16:19
@tonyredondo tonyredondo marked this pull request as ready for review January 10, 2025 16:19
@tonyredondo tonyredondo requested review from a team as code owners January 10, 2025 16:19
@tonyredondo tonyredondo force-pushed the tony/civisibility-improve-environment-tags-mutability branch from 35f1c3c to c5e1990 Compare January 10, 2025 16:33
@pr-commenter
Copy link

pr-commenter bot commented Jan 10, 2025

Benchmarks

Benchmark execution time: 2025-01-10 17:16:04

Comparing candidate commit c5e1990 in PR branch tony/civisibility-improve-environment-tags-mutability with baseline commit 27624f6 in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 57 metrics, 1 unstable metrics.

scenario:BenchmarkSetTagString-24

  • 🟥 execution_time [+4.502ns; +6.718ns] or [+3.908%; +5.832%]

@darccio
Copy link
Member

darccio commented Jan 13, 2025

No impact on reported benchmarks. The PR looks fine.

@tonyredondo tonyredondo merged commit 42997e1 into main Jan 13, 2025
160 checks passed
@tonyredondo tonyredondo deleted the tony/civisibility-improve-environment-tags-mutability branch January 13, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants