Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate statsd client to stats concentrator (APMSP-1631) #3007

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

ajgajg1134
Copy link
Contributor

What does this PR do?

Propagate statsd client to stats concentrator so we can emit health metrics about stats.

Motivation

Turns out these stats were never actually being written as the client was always a noopClient

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@ajgajg1134 ajgajg1134 changed the title Propagate statsd client to stats concentrator Propagate statsd client to stats concentrator (APMSP-1631) Dec 4, 2024
@ajgajg1134 ajgajg1134 marked this pull request as ready for review December 4, 2024 19:19
@ajgajg1134 ajgajg1134 requested a review from a team as a code owner December 4, 2024 19:19
@ajgajg1134
Copy link
Contributor Author

it looks like the smoke test failure here is due to be fixed here? #3006

@datadog-datadog-prod-us1
Copy link

Datadog Report

Branch report: andrew.glaude/statsmetrics
Commit report: 99cb26a
Test service: dd-trace-go

✅ 0 Failed, 5094 Passed, 67 Skipped, 2m 50.84s Total Time

Copy link
Contributor

@hannahkm hannahkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@pr-commenter
Copy link

pr-commenter bot commented Dec 4, 2024

Benchmarks

Benchmark execution time: 2024-12-04 19:56:45

Comparing candidate commit 7cd5754 in PR branch andrew.glaude/statsmetrics with baseline commit 9980c24 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics.

Copy link
Member

@darccio darccio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit: now I saw @ajgajg1134 comment about this:

cannot use t.statsd (variable of type "gopkg.in/DataDog/dd-trace-go.v1/internal".StatsdClient) as runtimemetrics.partialStatsdClientInterface value in argument to runtimemetrics.Start: "gopkg.in/DataDog/dd-trace-go.v1/internal".StatsdClient does not implement runtimemetrics.partialStatsdClientInterface (missing method DistributionSamples)

Edit 2: And now I see why. github.com/DataDog/go-runtime-metrics-internal package introduced a breaking change in a commit we are not pulling yet in our go.mod, but smoke tests do. That's why they fail. I'm reviewing and accepting #3006 to fix that.

@darccio darccio merged commit 7f02289 into main Dec 9, 2024
160 of 161 checks passed
@darccio darccio deleted the andrew.glaude/statsmetrics branch December 9, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants