-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate statsd client to stats concentrator (APMSP-1631) #3007
Conversation
it looks like the smoke test failure here is due to be fixed here? #3006 |
Datadog ReportBranch report: ✅ 0 Failed, 5094 Passed, 67 Skipped, 2m 50.84s Total Time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
BenchmarksBenchmark execution time: 2024-12-04 19:56:45 Comparing candidate commit 7cd5754 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edit: now I saw @ajgajg1134 comment about this:
cannot use t.statsd (variable of type "gopkg.in/DataDog/dd-trace-go.v1/internal".StatsdClient) as runtimemetrics.partialStatsdClientInterface value in argument to runtimemetrics.Start: "gopkg.in/DataDog/dd-trace-go.v1/internal".StatsdClient does not implement runtimemetrics.partialStatsdClientInterface (missing method DistributionSamples)
Edit 2: And now I see why. github.com/DataDog/go-runtime-metrics-internal
package introduced a breaking change in a commit we are not pulling yet in our go.mod
, but smoke tests do. That's why they fail. I'm reviewing and accepting #3006 to fix that.
What does this PR do?
Propagate statsd client to stats concentrator so we can emit health metrics about stats.
Motivation
Turns out these stats were never actually being written as the client was always a noopClient
Reviewer's Checklist
v2-dev
branch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!