Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddtrace/tracer: remove health_metrics_enabled from startup logs #3003

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

hannahkm
Copy link
Contributor

@hannahkm hannahkm commented Dec 2, 2024

What does this PR do?

Removes the health_metrics_enabled info from the startup logs.

Motivation

The health metrics are enabled by default on the Go tracer, and cannot be disabled. It is misleading to include health_metrics_enabled in the startup logs. Also, the logs were inaccurate (using runtime metrics to determine if the health metrics were "enabled").

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@hannahkm hannahkm marked this pull request as ready for review December 2, 2024 20:27
@hannahkm hannahkm requested a review from a team as a code owner December 2, 2024 20:27
@hannahkm hannahkm merged commit 5dcc739 into main Dec 2, 2024
159 of 160 checks passed
@hannahkm hannahkm deleted the hannah/remove_health_metrics_from_startup branch December 2, 2024 20:38
hannahkm added a commit that referenced this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants