Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/civisibility: add more nil checks to increase resilience #2944

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

tonyredondo
Copy link
Member

What does this PR do?

Add more nil checks on the CI Visibility library to either workaround possible crash, or panic with a better error message.

Motivation

Try to increase library resilience

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@tonyredondo tonyredondo requested a review from a team as a code owner October 23, 2024 22:40
@DataDog DataDog deleted a comment from pr-commenter bot Oct 24, 2024
@tonyredondo tonyredondo merged commit 7f5a7c9 into main Oct 24, 2024
150 checks passed
@tonyredondo tonyredondo deleted the tony/civisibility-add-missing-nil-checks branch October 24, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants