Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/civisibility: adds the new vcpu_count metric for tslv events #2883

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

tonyredondo
Copy link
Member

What does this PR do?

This PR adds the new _dd.host.vcpu_count metric to all test suite level visibility events.

Motivation

This new tag will be used by the backend to do some calculations.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@tonyredondo tonyredondo requested a review from a team as a code owner September 20, 2024 09:38
@tonyredondo tonyredondo self-assigned this Sep 20, 2024
@pr-commenter
Copy link

pr-commenter bot commented Sep 20, 2024

Benchmarks

Benchmark execution time: 2024-09-20 10:02:59

Comparing candidate commit e5d6ee5 in PR branch tony/civisibility-add-vcpucount-tag with baseline commit 054d19d in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics.

@tonyredondo tonyredondo merged commit 8860b39 into main Sep 20, 2024
144 of 145 checks passed
@tonyredondo tonyredondo deleted the tony/civisibility-add-vcpucount-tag branch September 20, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants